New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement of AssetServer::load documentation to help find a way to load from file with hash in filename #13272
base: main
Are you sure you want to change the base?
Improvement of AssetServer::load documentation to help find a way to load from file with hash in filename #13272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this feature but I feel pretty strongly that these should be constructor methods rather than From impls. They're easier to discover and much nicer to document: even just the method and argument names make things a lot less error prone.
@alice-i-cecile I used From<(Path, label)> because AssetServer::load uses |
May be we should improve just AssetServer::load doc-comment with explicit path and label example |
Great idea :) That's definitely my preference. |
31c6743
to
d3a92a4
Compare
d3a92a4
to
dead8ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just remember to update the title and PR description!
@alice-i-cecile Is there anything else I could do to move forward? |
Objective
Solution