Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/BEAM-3815 - Switching accounts too fast throw error with HeartBeat #2859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabrielbeamable
Copy link
Contributor

Attempt to fix issue with heartbeat erroring while users are being changed

Ticket

https://disruptorbeam.atlassian.net/browse/BEAM-3815

Brief Description

If you change users fast enough and while the SDK is sending a HeartBeat to the server, it's possible to get
an error where it complains that the user being sent by the HeartBeat is not the actual user.

Now we are waiting for an user change to happen before sending the heartbeat. The error still might occur in
the case that, for some weird reason not found yet, the heartbeat was send before the user start changing, and
somehow the change happens before the heartbeat finishs.

Checklist

  • Have you added appropriate text to the CHANGELOG.md files?

Add those to list or remove the list below altogether:

Notes

When you are merging a feature branch into main, please squash merge and make sure the final commit contains any relevent JIRA ticket number. If you are merging from main to staging, or staging to production, please use a regular merge commit.

Does this introduce tech-debt? If so, have you added an entry to the Tech-debt document?

@gabrielbeamable
Copy link
Contributor Author

Not sure if this is worth adding a line to the changelog, what do you think?

@github-actions
Copy link
Contributor

Lightbeam link

Copy link
Collaborator

@cdhanna cdhanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this- but I'm not convinced we should merge it without a better understanding of what is happening. I know that sucks, and it means this PR is going to sit dormant for most of the sprint. I want to make sure we feel confident in the code we push into main.

@gabrielbeamable gabrielbeamable changed the title Fix/BEAM-3815 Fix/BEAM-3815 - Switching accounts too fast throw error with HeartBeat Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants