[BEAM-3517] SDK - Fix Listing Scheduler all day daily #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have a WebGL build, friend. d91b96de302257633d672974ae05394c59bcdf68 |
molaycule
commented
Sep 4, 2023
client/Packages/com.beamable/Editor/UI/Schedules/ScheduleParser.cs
Outdated
Show resolved
Hide resolved
|
Have a WebGL build, friend. cf87c366e8d750efab9efb8a7f42e18bd0ad3251 |
cdhanna
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Hmm, I get that this is going to be tricky, but "all day, every day" does not map to 1 0 0 * * *.
That cron string translates to, "on the second second of the first minute of the first hour, every day".
I think when we talked with Drazen, he was saying the schedule we actually want is 3 compound statements.
-
- 0-23 * * * *
-
1-59 0 * * * *
1-59 0 0 * * * *
Is it possible to make that work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://disruptorbeam.atlassian.net/browse/BEAM-3517
Brief Description
Fix Listing Scheduler all day daily set to first second of the first hour daily
Checklist
Notes
When you are merging a feature branch into
main, please squash merge and make sure the final commit contains any relevent JIRA ticket number. If you are merging frommaintostaging, orstagingtoproduction, please use a regular merge commit.Does this introduce tech-debt? If so, have you added an entry to the Tech-debt document?