Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-2976] Analytics added to MS, cleanup #1624

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Leinnan
Copy link
Collaborator

@Leinnan Leinnan commented Sep 8, 2022

Ticket

Brief Description

Checklist

Notes

When you are merging a feature branch into main, please squash merge and make sure the final commit contains any relevent JIRA ticket number. If you are merging from main to staging, or staging to production, please use a regular merge commit.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Have a WebGL build, friend. 7a52dc1c53403da8a130a6e9bf496fda7f4a6286

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Have a WebGL build, friend. 4692417aab2e9bbf14905561740d836081af7502

Copy link
Collaborator

@cdhanna cdhanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We hit a snag very similar to this when we did the 1.3 release- moving some of the classes out of the Beamable core runtime asmdef and into the common asmdef caused backwards compat issues.

I guess I don't really see a way around it, but it may mean we need to 2.0 this?

@cdhanna cdhanna added this to the 2.0.0 milestone Sep 22, 2022
@Leinnan Leinnan added the breaking-change This issue or PR is going to break functionality and needs to await for a major release label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This issue or PR is going to break functionality and needs to await for a major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants