[helpers TS conversion] classes #16511
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56990 |
|
Thanks! For compatibility, we need to keep |
| var _typeof = require("./typeof.js")["default"]; | ||
| var assertThisInitialized = require("./assertThisInitialized.js"); | ||
|
|
||
| function _possibleConstructorReturn<T, U>(t: T, e: U): U | T { |
There was a problem hiding this comment.
Is it possible to migrate to export default? Let's give it a shot and see if the make test passes.
There was a problem hiding this comment.
should I also convert require() to use esm import?
@SukkaW
There was a problem hiding this comment.
The files in this directory should be automatically generated and we should not edit it manually.
There was a problem hiding this comment.
oh yeah you're right
there is another file called possibleConstructorReturn.js in packages/babel-helpers/src/helpers/possibleConstructorReturn.js
which has the same name as this one
should I also convert it to typescript?
There was a problem hiding this comment.
Yes, we should convert packages/babel-helpers/src/helpers/possibleConstructorReturn.js and remove this.
make the function accept undefined as a param type Co-authored-by: Sukka <isukkaw@gmail.com>
I must have changed it out of habit unconsciously reverted! @liuxingbaoyu |
|
Did you forget to push your changes? :) |
|
pushed |
| import toPropertyKey from "toPropertyKey"; | ||
| function _defineProperties(target, props) { | ||
| // @ts-expect-error Migrate in another PR | ||
| import toPropertyKey from "toPropertyKey.ts"; |
There was a problem hiding this comment.
| import toPropertyKey from "toPropertyKey.ts"; | |
| import toPropertyKey from "./toPropertyKey.ts"; |
(and it's already written in TS :) )
| export default function _possibleConstructorReturn< | ||
| T extends object | undefined, | ||
| >(self: T, call: T | ((...args: any[]) => T) | undefined) { |
There was a problem hiding this comment.
While we are here, let's rename call to value. Calling it call makes absolutely no sense 😅
It's the value passed to return in a derived class constructor:
class A extends B {
constructor() {
return 1;
}
}"call" is 1 in this case.
(and probably it's type should just be any or unknown)
There was a problem hiding this comment.
ok!!
that makes much sense now!
Migrate all classes helper functions (createClass, possibleConstructorReturn, classCallCheck, assertThisInitialized) to TypeScript