Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Spells/SpellInfoCorrections) Remove friendly mask on goblins #18912

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pangolp
Copy link
Contributor

@pangolp pangolp commented May 18, 2024

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).

Issues Addressed:

Tests Performed:

This PR has been:

  • Tested in-game by the author.

How to Test the Changes:

  1. .tele area52 with 2 opposite faction player
  2. Fight inside Area 52
  3. The guards will start hitting you if you put up a fight.
2024-04-30.01-28-31.mp4

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Co-authored-by: Jelle Meeus <sogladev@gmail.com>
@github-actions github-actions bot added CORE Related to the core Script file-cpp Used to trigger the matrix build labels May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core file-cpp Used to trigger the matrix build Ready to be Reviewed Script
Projects
None yet
2 participants