-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(Core/Color): ClassColor #18911
Fix(Core/Color): ClassColor #18911
Conversation
Can you please provide information on how to test these changes? Thanks! |
I've tested it, and there's no code referencing this |
|
what about another PR to use these colors within Chat.h -> playerLink()? |
can you please rerun your conversion script and round the result instead of casting it to "int" directly? I have the feeling that this would lead to the same values that are already present in AC. e.g. the first line of your converted data: which is the existing value for |
I'll close this PR for now, for the reason in my comment above. IMO when executed correctly this PR would not propose any changes at all as the colors are identical to the client values. |
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
It was extracted from the client and calculated to arrive at it
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.