fix(Core/ItemScript): make some more pets play Fetch Ball #18906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DB
|
draft, missing a list of creatureIds of the companions that can/cannot play fetch |
|
added companions https://wowgaming.altervista.org/aowow/?npcs=12, skipped "darkmoon faire" pets from JC trinkets, companions summoned by NPCs, orphans, non-fetch pets like zeppelins/kites Added entries: |
Kitzunu
approved these changes
Jun 1, 2024
Kitzunu
reviewed
Jun 1, 2024
ikkj
pushed a commit
to ikkj/AzerothCore-wotlk-with-NPCBots
that referenced
this pull request
Jun 10, 2024
* refactor use enum for spellIds * add sql * update sql * enclose Comment with backticks ` * Closes azerothcore#565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
refactor spellIds using Enum
The ball that spawns casts "ID - 48649 Pet Toy - Fetch Stick - Come Here". Conditions decide which companion entry can fetch.
This adds the following to these conditions:
Issues Addressed:
SOURCE:
The changes have been validated through:
In the comments are lists of pets that can fetch.
https://www.wowhead.com/item=37431/fetch-ball#comments
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.