fix(ICC/Sindragosa): add a cooldown to proccing Unchained Magic

[sogladev]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

first commit contains the logic changes: 25b6102

Issues Addressed:

• Closes (Instance/IcecrownCitadel): Sindragosa's Unchained Magic has possibly incorrect proc behavior. #17664

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

a OG wrath PTR video shows the effect, debuffs are shows on the right

4:21 shadowbolt -> agony, delay ~1second, 2 stacks

https://youtu.be/ezuDqODdADA?si=fj_1bPlF5LagoOia&t=261

6:11 shadowbolt -> agony, delay <1 sec, 1 stack

https://youtu.be/ezuDqODdADA?si=i85-7vyBFM9rTn_M&t=370

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

learn healing touch, rejuv

.learn 774
.learn 5185

learn shadowbolt, corruption

.learn 686
.learn 172

tp to sindy's room

.go xyz 4304 2484.62 211 631 6.27

`.cheat power`

Known Issues and TODO List:

• Should spells like Starfall which trigger spells proc multiple stacks? As of now only the original cast triggers, resulting in 1 stack
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[heyitsbench]

Should spells like Starfall which trigger spells proc multiple stacks? As of now only the original cast triggers, resulting in 1 stack

From what I can tell, it does seem they're only supposed to apply a stack on the initial cast, so one stack seems to be correct.

[PkllonG]

Tested d73da98

[Nyeriah]

I'm positive there is a database table that handles ICD on procs

[sogladev]

spell_cooldown_overrides exists

https://www.azerothcore.org/wiki/spell_proc#cooldown table is empty

https://www.azerothcore.org/wiki/spell_proc_event#cooldown

UPDATE spell_proc_event SET Cooldown=600 WHERE entry=69762;

potential fix, will try it out later