-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Core/Pets): Correct Pet size for bigger pets 2 #18867
base: master
Are you sure you want to change the base?
Conversation
Too big not fit for the game fighting to boss, normaly the pet large not than the biggest player module is better, such as Minotaurs |
and I think now module is fit for play the game |
and the module scale change has been repeated several times, and every time you mess with the boss if the pet too big, players complain more about blocking the screen view |
so I dont think this is a problem or a real game problem |
881786a Seems to prevent mobs scaling too large I have no data on how the tamed creature's size translates into pet size. DBC Scaling is a factor for sure. Issue are some wotlk exotic pets like core hounds, rhinos, worms are smaller than they should be. An alternative fix is adding these families to the current check |
This comment was marked as off-topic.
This comment was marked as off-topic.
Tested 881786a |
I'm not able to reproduce the big Silithid #18867 (comment) I went through and spawned the mobs from https://www.wow-petopia.com/classic_lk/family.php?id=silithid Taming large model Xil'xix (15286) looks fine on my end I don't recognize the model from the picture. I tried the HD patch to see if it had an effect "Updated Creature Models by vvladoon" from https://github.com/Marotheit/A-Guide-to-Modernizing-the-WotLK-Client . The model doesn't match to the pic, but the size of the models look fine |
Anymore I think now scale is BLZ game size, I never see so big pets when play at BLZ WLK |
http://wow.yzz.cn/official/guofu/201009/200927_2.shtml |
Changes Proposed:
This PR proposes changes to:
Pets should scale based on level and scaling range as by their DBC value. I found that this also needs to be scaled with their DisplayID, this part was missing.
This factor was added in PR
Adding it back seemed correct besides that the scaling was not capped to MaxScaling. So pets past the MaxScaleLevel were still scaled larger than they should
Issues Addressed:
SOURCE:
The changes have been validated through:
DBC
https://old.wow.tools/dbc/?dbc=creaturefamily&build=3.3.5.12340#page=1
PR #14511
formula check, scaling is correct until maxLvl
Tests Performed:
This PR has been:
How to Test the Changes:
Spawn NPCs and tame
.npc tame
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.