Adds a new Ask to questioner for bools with a default value. Also adds tests. #6449
+68
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beqqrry-aws
added
Go-v2
Laren-AWS
approved these changes
May 10, 2024
gov2/demotools/question.go
Outdated
Comment on lines
144
to
147
| func (questioner Questioner) AskBoolWithDefault(question string, expected string, defaultValue string) bool { | ||
| answer := questioner.Ask(question) | ||
| return strings.ToLower(answer) == expected || strings.ToLower(expected) == strings.ToLower(defaultValue) | ||
| } |
There was a problem hiding this comment.
This works fine, but I almost would prefer defaultResponse bool instead of defaultValue and then
return strings.ToLower(answer) == expected || defaultResponse
There was a problem hiding this comment.
This made me realize I was missing some test coverage for when the default response is affirmative but the provided response by the user is negative. I'll rewrite and then take a look at using a bool instead of a string.
beqqrry-aws
force-pushed
the
go_demotools_add_ask_book_default
branch
from
fb1289e
to
4729243
Compare
Laren-AWS
requested changes
May 10, 2024
Comment on lines
+61
to
+99
| func TestQuestioner_AskBoolWithDefault_yY_Blank(t *testing.T) { | ||
| AskBoolWithDefault_ByArguments(t, "y", "Y", "", true) | ||
| } | ||
|
|
||
| func TestQuestioner_AskBoolWithDefault_yN_Blank(t *testing.T) { | ||
| AskBoolWithDefault_ByArguments(t, "y", "N", "", false) | ||
| } | ||
| func TestQuestioner_AskBoolWithDefault_nY_Blank(t *testing.T) { | ||
| AskBoolWithDefault_ByArguments(t, "n", "Y", "", false) | ||
| } | ||
| func TestQuestioner_AskBoolWithDefault_nN_Blank(t *testing.T) { | ||
| AskBoolWithDefault_ByArguments(t, "n", "N", "", true) | ||
| } | ||
|
|
||
| func TestQuestioner_AskBoolWithDefault_yY_y(t *testing.T) { | ||
| AskBoolWithDefault_ByArguments(t, "y", "Y", "y", true) | ||
| } | ||
| func TestQuestioner_AskBoolWithDefault_yN_y(t *testing.T) { | ||
| AskBoolWithDefault_ByArguments(t, "y", "N", "y", true) | ||
| } | ||
| func TestQuestioner_AskBoolWithDefault_nY_y(t *testing.T) { | ||
| AskBoolWithDefault_ByArguments(t, "n", "Y", "y", false) | ||
| } | ||
| func TestQuestioner_AskBoolWithDefault_nN_y(t *testing.T) { | ||
| AskBoolWithDefault_ByArguments(t, "n", "N", "y", false) | ||
| } | ||
|
|
||
| func TestQuestioner_AskBoolWithDefault_yY_n(t *testing.T) { | ||
| AskBoolWithDefault_ByArguments(t, "y", "Y", "n", false) | ||
| } | ||
| func TestQuestioner_AskBoolWithDefault_yN_n(t *testing.T) { | ||
| AskBoolWithDefault_ByArguments(t, "y", "N", "n", false) | ||
| } | ||
| func TestQuestioner_AskBoolWithDefault_nY_n(t *testing.T) { | ||
| AskBoolWithDefault_ByArguments(t, "n", "Y", "n", true) | ||
| } | ||
| func TestQuestioner_AskBoolWithDefault_nN_n(t *testing.T) { | ||
| AskBoolWithDefault_ByArguments(t, "n", "N", "n", true) | ||
| } |
There was a problem hiding this comment.
I think a lot of these are redundant, because y or n doesn't matter, it's more like a or b, and aA or bB are equivalent, so your set of cases should be:
aA""
aB""
aAa
aAb
aBa
aBb
It might not be fewer lines, but I might have made a struct and then a list of objects, like:
type testArgs struct {
expected string
defaultVal string
entry string
result bool
}
tests := []testArgs{
{"a", "A", "", true},
... etc ...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.