Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(synthetics): update Canary runtime in unit tests and integ tests #30269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented May 19, 2024

Issue # (if applicable)

N/A

Reason for this change

Runtimes in unit tests and integ tests are outdated.

Description of changes

  • update runtime in unit tests and integ tests
  • In integ.vpc.ts, improve it to use IntegTest for making assertions.

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label May 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 19, 2024 11:35
@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label May 19, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 11dfb58
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 19, 2024
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is valid to add test cases for new runtimes but we should not be removing test coverage for older runtimes. If a user can still use them we must have tests on them.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 3, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 4, 2024

@TheRealAmazonKendra
Thank you for the review.

I was upgrading the versions of unit tests and integration tests referring to #30219.
Could you please advise on how to handle cases like this? (For example, adding new versions of unit tests and integration tests, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants