Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cdk): update the fact tables and tests for lambda layers v0.98.0 #30263

Closed
wants to merge 3 commits into from

Conversation

humivo
Copy link
Contributor

@humivo humivo commented May 17, 2024

Update ADOT Lambda Layer ARNs for recent release


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels May 17, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 17, 2024 20:21
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@humivo humivo changed the title chore(cdk): Update the fact tables and tests for lambda layers v0.98.0 chore(cdk): update the fact tables and tests for lambda layers v0.98.0 May 17, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 17, 2024 20:28

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 17, 2024
Comment on lines +71 to +73
| [@aws-cdk/aws-ec2:ebsDefaultGp3Volume](#aws-cdkaws-ec2ebsdefaultgp3volume) | When enabled, the default volume type of the EBS volume will be GP3 | 2.140.0 | (default) |
| [@aws-cdk/pipelines:reduceAssetRoleTrustScope](#aws-cdkpipelinesreduceassetroletrustscope) | Remove the root account principal from PipelineAssetsFileRole trust policy | 2.141.0 | (default) |
| [@aws-cdk/aws-ecs:removeDefaultDeploymentAlarm](#aws-cdkaws-ecsremovedefaultdeploymentalarm) | When enabled, remove default deployment alarm settings | V2NEXT | (default) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these changes and why are they here in this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this change might be added by default when huy had built the package in local at the time of PR. By updating the branch of the PR it should fix i guess. unfortunately i dont' have permissions to do that, since i didn't create it. hey Gavin, is it possible for you update the branch or do you recommend me creating a new PR with these changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GavinZZ i have created this PR - #30448 can you help review/merge

@GavinZZ
Copy link
Contributor

GavinZZ commented Jun 3, 2024

@mergify update

Copy link
Contributor

mergify bot commented Jun 3, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@vasireddy99
Copy link
Contributor

@mergify update

Do you think it has to be done manually :(

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fe4d694
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@vasireddy99
Copy link
Contributor

@mergify update

Copy link
Contributor

mergify bot commented Jun 3, 2024

update

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • any of:
    • sender-permission>=write
    • sender={{author}}

@vasireddy99
Copy link
Contributor

@mergify update

This PR can be closed as the task will be done by #30448, created new pr to have control over the changes

mergify bot pushed a commit that referenced this pull request Jun 5, 2024
#30448)

Update ADOT Lambda Layer ARNs for recent release

aws-observability/aws-otel-lambda#922

includes the PR changes - #30263

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants