Model parallel v2 llama finetuning notebook fixes #4646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 29, 2024 14:18
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
SuhitK
reviewed
May 6, 2024
| @@ -27,7 +27,7 @@ def parse_args(): # pylint: disable=too-many-statements | |||
| opt_grp.add_argument("--seed", type=int, default=12345) | |||
| opt_grp.add_argument("--same_seed", type=int, default=0) | |||
| opt_grp.add_argument("--bf16", default=1, type=int, help="automatic mixed precision training") | |||
| opt_grp.add_argument("--fp8", default=1, type=int, help="fp8 mixed precision training") | |||
| opt_grp.add_argument("--fp8", default=0, type=int, help="fp8 mixed precision training") | |||
There was a problem hiding this comment.
Did you run into any issues with the default enabled? Normally, fp8 will only be enabled for models that support fp8 and should switch to bf16 for other cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing done:
Ran smp-finetuning-llama-fsdp-tp.ipynb in sagemaker notebook and ensured sagemaker training job succeded
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.black-nb -l 100 {path}/{notebook-name}.ipynbBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.