Plugin locations #6203
Merged
Plugin locations #6203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsverchinsky
force-pushed
the
i6156-plugin-locations
branch
from
54e4e05
to
19d1765
Compare
crsib
approved these changes
Apr 4, 2024
vsverchinsky
force-pushed
the
i6156-plugin-locations
branch
from
19d1765
to
43396a4
Compare
grliszas14
reviewed
May 13, 2024
|
|
||
| mRows->Add(rowSizer.release(), 0, wxEXPAND); | ||
|
|
||
| if(setFocus) |
There was a problem hiding this comment.
I know that there's only one line after "if" statement but I'd add curly braces anyway - I've seen too many bugs with it
There was a problem hiding this comment.
We don't have a strict policy about use of brackets in if-statements, but generally in Audacity's sources brackets are not used with single line expressions.
| void AddLocations(const PluginPaths& paths) | ||
| { | ||
| for(const auto& location : paths) | ||
| AddLocation(location); |
There was a problem hiding this comment.
Same comment as above - consider using curly braces anyway
grliszas14
approved these changes
May 13, 2024
|
One more commit added that fixed scrolled window auto-size issue |
vsverchinsky
force-pushed
the
i6156-plugin-locations
branch
2 times, most recently
from
4d5637c
to
ec41df0
Compare
grliszas14
approved these changes
May 17, 2024
vsverchinsky
force-pushed
the
i6156-plugin-locations
branch
from
ec41df0
to
69d84d8
Compare
|
Squashed fix commits |
vsverchinsky
force-pushed
the
i6156-plugin-locations
branch
2 times, most recently
from
e4d9b9f
to
38a614b
Compare
|
One new commit @vsverchinsky |
grliszas14
approved these changes
May 27, 2024
vsverchinsky
force-pushed
the
i6156-plugin-locations
branch
from
35a179e
to
7b3875c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #6156
Recommended: