A fuzzed stride could cause the max count to become negative and henc… #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e wrap around uint
|
Not a big deal in reality, but it's always good to harden the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fuzzed stride could cause the max count to become negative and hence wrap around uint
We have fuzzing tests that artificially break files. We want assimp to crash in a controlled way.
One case we now came across is that the fuzzer changed the stride of one buffer view:
"byteStride": 32769,
This caused the division maxSize / stride to become 0 and with the -1 wrap around to 0xffffffff for the uint.