Add unit test for subdivision modifier on Blender importer #5345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blend file is composed of default cube with subdivision modifier applied and same cube with subdivision modifier.
turol
reviewed
Nov 27, 2023
test/unit/utBlenderImportExport.cpp
Outdated
| Assimp::Importer importer; | ||
| const aiScene *scene = importer.ReadFile(ASSIMP_TEST_MODELS_DIR "/BLEND/subdivision_test_277.blend", aiProcess_ValidateDataStructure); | ||
| EXPECT_NE(nullptr, scene); | ||
| EXPECT_EQ(scene->mNumMeshes, 2); |
There was a problem hiding this comment.
This must be ASSERT_EQ to not crash on the next line in case of failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catmul-Clark subdivision modifier is implemented in Assimp but was lacking unit-test.
This PR add an unit-test of a Blend file composed of default cube with subdivision modifier applied and same cube with subdivision modifier.
Vertices should match if Assimp is running the subdivision code correctly.