Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallax Scrolling Backgrounds #698

Merged
merged 6 commits into from
Jun 8, 2024
Merged

Conversation

AntumDeluge
Copy link
Member

@AntumDeluge AntumDeluge commented Apr 8, 2024

Parallax scrolling support was added with 9257fe4. So this has been changed to just add parallax backgrounds to the following maps:

  • 6_kikareukin_islands
  • 7_kikareukin_clouds

The only problem that I am aware of is that the Java client will display a black background since tile information has been removed from those maps. Adding support is not planned, but might be good to at least think about researching a workaround that would use the old tiles.

Original Description

Proof of concept: https://www.youtube.com/watch?v=vyPkolxw5kY

Issues:

  • seams between tiles (still an issue when background image is smaller than map size)
  • jumps when tile group is shifted

There was some discussion about performance around April 7-8 that appears to not have been logged in IRC chat:

  • hendrik: How much CPU does it use.
  • AntumDeluge: Not sure yet. I would think that it would be similar to weather.
  • AntumDeluge: I added a parallax background to Semos Bank to test CPU usage. Firefox reports around 6.8% while idling when both enabled & disabled on this machine. While walking it is around 8%-9% for both. I have another system with less available resources. I will test it on that eventually.

screenshot

@AntumDeluge AntumDeluge self-assigned this Apr 8, 2024
@AntumDeluge AntumDeluge force-pushed the parallax branch 2 times, most recently from cfe7596 to 93bdde5 Compare April 8, 2024 07:39
@AntumDeluge AntumDeluge force-pushed the parallax branch 2 times, most recently from 427bc2e to 9086b6e Compare April 23, 2024 02:17
@AntumDeluge AntumDeluge force-pushed the parallax branch 2 times, most recently from 3399835 to ce72da4 Compare May 16, 2024 19:42
@AntumDeluge AntumDeluge force-pushed the parallax branch 4 times, most recently from 821467a to eb9278e Compare June 1, 2024 22:12
@AntumDeluge AntumDeluge force-pushed the parallax branch 2 times, most recently from f428012 to 86a41bd Compare June 6, 2024 15:57
@AntumDeluge AntumDeluge marked this pull request as ready for review June 6, 2024 16:09
@AntumDeluge AntumDeluge added the component: webclient Related to the web client. label Jun 6, 2024
@AntumDeluge AntumDeluge added this to the 1.48 milestone Jun 6, 2024
@AntumDeluge AntumDeluge force-pushed the parallax branch 2 times, most recently from f887590 to e844911 Compare June 8, 2024 06:41
@AntumDeluge AntumDeluge merged commit f9af9aa into arianne:master Jun 8, 2024
3 checks passed
@AntumDeluge AntumDeluge deleted the parallax branch June 8, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: webclient Related to the web client.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant