fix(deps): upgrade go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency #18285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Marquis <justin@akuity.io>
14 tasks
blakepettersson
approved these changes
May 20, 2024
14 tasks
gdsoumya
approved these changes
May 20, 2024
|
@crenshaw-dev Safe to cherry-pick now? |
|
@34fathombelow you can do it , we already released |
|
/cherry-pick release-2.11 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
May 21, 2024
Signed-off-by: Justin Marquis <justin@akuity.io> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com>
|
/cherry-pick release-2.10 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
May 21, 2024
Signed-off-by: Justin Marquis <justin@akuity.io> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com>
|
/cherry-pick release-2.9 |
|
Cherry-pick failed with |
34fathombelow
added a commit
that referenced
this pull request
May 21, 2024
34fathombelow
added a commit
that referenced
this pull request
May 21, 2024
14 tasks
rumstead
pushed a commit
to rumstead/argo-cd
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Justin Marquis <justin@akuity.io> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Justin Marquis <justin@akuity.io> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CVE-2023-47108
Opened #18258 to ensure we migrate from
interceptorstostat handlersin future versions of Argo CD.Upgraded to the lowest minor version that contained the patch. I had to exclude
StreamServerInterceptor&UnaryServerInterceptorfrom the linter checks to pass the depreciation warnings. Although migrating to the newer functions is preferred, going this route ensures no breaking changes when cherry picking the fix.Upstream has deprecated
StreamServerInterceptor,UnaryServerInterceptor, andStreamClientInterceptorfunctions but has not been removed as of the latest release (0.51.0).Built and tested with image:
quay.io/34fathombelow/argocd:latest-otel46.1cherry-pick
v2.11,v2.10, andv2.9?