Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HA proxy memory runaway on certain rpm based distro's -> Setting maxconn in haproxy config (#15319) #18283

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

timgriffiths
Copy link

Fixes #15319

I propose the best way to fix this issue is by setting a global setting in haproxy config maxconn 4000 you can also fix it by changing the max open file limit in containerd but as this comment points out docker-library/haproxy#194 (comment) this only works as haproxy derives the max number of connections from the max open files on a system which seems like a bit of a bug or at least we should set a max as part of the config.

Setting the default sufficiently large so that this should not be a problem. this could be backported to whichever versions users need as it's a simple haproxy config tweak

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.94%. Comparing base (8a28279) to head (c6d8731).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #18283   +/-   ##
=======================================
  Coverage   44.94%   44.94%           
=======================================
  Files         354      354           
  Lines       47740    47740           
=======================================
  Hits        21455    21455           
  Misses      23482    23482           
  Partials     2803     2803           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

based systems

Signed-off-by: Timothy Griffiths <griffiths.timothy@gmail.com>
Signed-off-by: Timothy Griffiths <griffiths.timothy@gmail.com>
Signed-off-by: Timothy Griffiths <griffiths.timothy@gmail.com>
Signed-off-by: Timothy Griffiths <griffiths.timothy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HA install's argocd-redis-ha-haproxy pods have runaway memory consumption
1 participant