-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added the comment to support CLI message to get extended output #18253
Conversation
…rgoproj#18226 Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>
@nikzayn you need to run |
Thanks, for updating. I will do that. |
Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikzayn , it seems the manifests are not generated properly. Can you execute make manifests
or make manifests-local
and push the changes?
Hey @ishitasequeira, I tried running both commands but no changes are happening at the repo which I can commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you execute make codegen-local
? That should fix the generated code.
I tried running this, and it gave me this error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make sure you have the correct protogen
version installed locally?
You could use install-tools-local
to have all the correct version of tools installed
Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>
Thanks for this, I have run this command and added the changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18253 +/- ##
=======================================
Coverage 45.68% 45.68%
=======================================
Files 353 353
Lines 46965 46965
=======================================
Hits 21454 21454
Misses 22772 22772
Partials 2739 2739 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nikzayn !! LGTM!!
…argoproj#18253) * feat: Added the comment to support CLI message to get extended output argoproj#18226 Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> * feat: Updated proto and swagger argoproj#18226 Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> * feat: Updated manifest files Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> --------- Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
…argoproj#18253) * feat: Added the comment to support CLI message to get extended output argoproj#18226 Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> * feat: Updated proto and swagger argoproj#18226 Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> * feat: Updated manifest files Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> --------- Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
#18226
Added the comment to support CLI message to get extended output
Checklist: