Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding gocover to e2e tests (#18130) #18247

Closed
wants to merge 126 commits into from
Closed

feat: adding gocover to e2e tests (#18130) #18247

wants to merge 126 commits into from

Conversation

rumstead
Copy link
Contributor

@rumstead rumstead commented May 16, 2024 •
edited

closes #18130

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@rumstead rumstead changed the title WIP feat: adding gocover to e2e tests feat: adding gocover to e2e tests (#18130) May 16, 2024
@rumstead rumstead marked this pull request as ready for review May 16, 2024 14:43
@rumstead rumstead requested review from a team as code owners May 16, 2024 14:43
@crenshaw-dev
Copy link
Collaborator

Thanks for the PR! Can you rebase? Codecov report uploading was broken.

@rumstead
Copy link
Contributor Author

Thanks for the PR! Can you rebase? Codecov report uploading was broken.

Done! However, I am not 100% sure how to test this. I have a feeling this won't work the first time.

@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.90%. Comparing base (c264705) to head (bb54a89).

❗ Current head bb54a89 differs from pull request most recent head c33f382

Please upload reports for the commit c33f382 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #18247      +/-   ##
==========================================
- Coverage   44.99%   44.90%   -0.10%     
==========================================
  Files         355      354       -1     
  Lines       47925    47705     -220     
==========================================
- Hits        21564    21421     -143     
+ Misses      23561    23488      -73     
+ Partials     2800     2796       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Collaborator

Looks like codecov is uploading, but the coverage amount hasn't changed... will look tomorrow

@rumstead
Copy link
Contributor Author

rumstead commented Jun 3, 2024

Looks like codecov is uploading, but the coverage amount hasn't changed... will look tomorrow

Run go tool covdata percent -i=./test-results -o test-results/full-coverage.out
warning: no applicable files found in input directories

Checking https://github.com/argoproj/argo-cd/actions/runs/9341278349/job/25707896658?pr=18247 and the uploading e2e coverage report

Run actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808
Warning: No files were found with the provided path: /test-results/cov*. No artifacts will be uploaded.

I think I had a bad path

rumstead
rumstead commented Jun 3, 2024
View reviewed changes
Procfile Outdated
@@ -1,13 +1,13 @@
controller: [ "$BIN_MODE" = 'true' ] && COMMAND=./dist/argocd || COMMAND='go run ./cmd/main.go' && sh -c "HOSTNAME=testappcontroller-1 FORCE_LOG_COLORS=1 ARGOCD_FAKE_IN_CLUSTER=true ARGOCD_TLS_DATA_PATH=${ARGOCD_TLS_DATA_PATH:-/tmp/argocd-local/tls} ARGOCD_SSH_DATA_PATH=${ARGOCD_SSH_DATA_PATH:-/tmp/argocd-local/ssh} ARGOCD_BINARY_NAME=argocd-application-controller $COMMAND --loglevel debug --redis localhost:${ARGOCD_E2E_REDIS_PORT:-6379} --repo-server localhost:${ARGOCD_E2E_REPOSERVER_PORT:-8081} --otlp-address=${ARGOCD_OTLP_ADDRESS} --application-namespaces=${ARGOCD_APPLICATION_NAMESPACES:-''} --server-side-diff-enabled=${ARGOCD_APPLICATION_CONTROLLER_SERVER_SIDE_DIFF:-'false'}"
api-server: [ "$BIN_MODE" = 'true' ] && COMMAND=./dist/argocd || COMMAND='go run ./cmd/main.go' && sh -c "FORCE_LOG_COLORS=1 ARGOCD_FAKE_IN_CLUSTER=true ARGOCD_TLS_DATA_PATH=${ARGOCD_TLS_DATA_PATH:-/tmp/argocd-local/tls} ARGOCD_SSH_DATA_PATH=${ARGOCD_SSH_DATA_PATH:-/tmp/argocd-local/ssh} ARGOCD_BINARY_NAME=argocd-server $COMMAND --loglevel debug --redis localhost:${ARGOCD_E2E_REDIS_PORT:-6379} --disable-auth=${ARGOCD_E2E_DISABLE_AUTH:-'true'} --insecure --dex-server http://localhost:${ARGOCD_E2E_DEX_PORT:-5556} --repo-server localhost:${ARGOCD_E2E_REPOSERVER_PORT:-8081} --port ${ARGOCD_E2E_APISERVER_PORT:-8080} --otlp-address=${ARGOCD_OTLP_ADDRESS} --application-namespaces=${ARGOCD_APPLICATION_NAMESPACES:-''}"
controller: [ "$BIN_MODE" = 'true' ] && COMMAND=./dist/argocd || COMMAND='go run ./cmd/main.go' && sh -c "GOCOVERDIR="test-results" HOSTNAME=testappcontroller-1 FORCE_LOG_COLORS=1 ARGOCD_FAKE_IN_CLUSTER=true ARGOCD_TLS_DATA_PATH=${ARGOCD_TLS_DATA_PATH:-/tmp/argocd-local/tls} ARGOCD_SSH_DATA_PATH=${ARGOCD_SSH_DATA_PATH:-/tmp/argocd-local/ssh} ARGOCD_BINARY_NAME=argocd-application-controller $COMMAND --loglevel debug --redis localhost:${ARGOCD_E2E_REDIS_PORT:-6379} --repo-server localhost:${ARGOCD_E2E_REPOSERVER_PORT:-8081} --otlp-address=${ARGOCD_OTLP_ADDRESS} --application-namespaces=${ARGOCD_APPLICATION_NAMESPACES:-''} --server-side-diff-enabled=${ARGOCD_APPLICATION_CONTROLLER_SERVER_SIDE_DIFF:-'false'}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need to make the same changes to the test tool Procfile?

@rumstead
Copy link
Contributor Author

rumstead commented Jun 3, 2024

Didn't seem to help. When I run:

make install-test-tools-local
make start-e2e-local
make test-e2e-local

I see the test-results directory populated

❯ ls  test-results/cov* 
test-results/covcounters.59ea707707b901d5957baf3fc0fa64f0.12281.1715805185934105000 test-results/covcounters.c6bb65ce0a5fa66569a4cb1fc6efc6b4.40502.1717427615343989000
test-results/covcounters.59ea707707b901d5957baf3fc0fa64f0.12294.1715805187074782000 test-results/covcounters.c6bb65ce0a5fa66569a4cb1fc6efc6b4.40504.1717427620834574000
test-results/covcounters.c6bb65ce0a5fa66569a4cb1fc6efc6b4.39184.1717427697662708000 test-results/covcounters.c6bb65ce0a5fa66569a4cb1fc6efc6b4.40506.1717427621139324000
test-results/covcounters.c6bb65ce0a5fa66569a4cb1fc6efc6b4.39186.1717427417033107000 test-results/coverage.out
test-results/covcounters.c6bb65ce0a5fa66569a4cb1fc6efc6b4.40499.1717427617518722000 test-results/covmeta.59ea707707b901d5957baf3fc0fa64f0
test-results/covcounters.c6bb65ce0a5fa66569a4cb1fc6efc6b4.40500.1717427613681107000 test-results/covmeta.c6bb65ce0a5fa66569a4cb1fc6efc6b4

@rumstead
Copy link
Contributor Author

rumstead commented Jun 4, 2024

Ok after looking at the e2e-server.log I see the error for all the binaries.

19:20:11               repo-server | �[merror: coverage meta-data emit failed: output directory "test-results" inaccessible (err: stat test-results: no such file or directory); no coverage data written

rumstead and others added 17 commits June 6, 2024 11:34
@rumstead
feat: adding gocover to e2e tests
bb111fd 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
feat: uploading e2e test coverage with unit
8264b05 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
feat: uploading e2e test coverage with unit
72fe048 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
feat: uploading e2e test coverage with unit
0a4d3ef 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@morey-tech @rumstead
docs: expand appset post selector examples (argoproj#18257)
c75cdd9 
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@igaskin @rumstead
docs: update workflows readme (argoproj#18263)
561b326 
Signed-off-by: Isaac Gaskin <isaac.gaskin@circle.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@dependabot @rumstead
chore(deps): bump library/node from 22.1.0 to 22.2.0 in /ui-test (arg…
ec9d5ca 
…oproj#18260)

Bumps library/node from 22.1.0 to 22.2.0.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@dependabot @rumstead
chore(deps): bump library/node from 22.1.0 to 22.2.0 in /test/contain…
7a7b314 
…er (argoproj#18261)

Bumps library/node from 22.1.0 to 22.2.0.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@dependabot @rumstead
chore(deps): bump bitnami/kubectl in /test/container (argoproj#18262)
04b0418 
Bumps bitnami/kubectl from `09c66fb` to `0aef4af`.

---
updated-dependencies:
- dependency-name: bitnami/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@34fathombelow @todaywasawesome @rumstead
chore(deps): upgrade helm to 3.14.4 (argoproj#18255)
b8801fc 
* chore(deps): upgrade helm to 3.14.4

Signed-off-by: Justin Marquis <justin@akuity.io>

* place checksums where they belong

Signed-off-by: Justin Marquis <justin@akuity.io>

---------

Signed-off-by: Justin Marquis <justin@akuity.io>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@MioOgbeni @rumstead
fix(reposerver): fix OCI repository matching (argoproj#17955)
58a1a87 
Signed-off-by: Tomáš Novák <tomas.novak@bcas.cz>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@github-actions @rumstead
[Bot] docs: Update Snyk reports (argoproj#18276)
ed8578e 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@david-wu-octopus @rumstead
fix(ui): Fix excessive padding on system level extension pages (issue a…
8e7524e 
…rgoproj#17929) (argoproj#18207)

* Remove CSS class `.cd-layout--extension`

Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>

* Remove all usages of CSS class `.cd-layout--extension`

Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>

* Remove unused prop `isExtension` from `<Layout />`

Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>

* Remove unused property `extension` from type `Routes`

Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>

* Fix linting error

Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>

---------

Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@condaatje @rumstead
add apiVersion so yaml applies properly in-cluster (argoproj#18282)
911c429 
Signed-off-by: condaatje <condaatje@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@sunyeongchoi @rumstead
fix(ui): Add title for full content without clicking (issue argoproj#…
bbe769e 
…17600) (argoproj#18243)

* fix: Add title for full content without clicking

Signed-off-by: sunyeongchoi <suoung0716@gmail.com>

* fix: apply ui lint

Signed-off-by: sunyeongchoi <suoung0716@gmail.com>

* fix: apply argo-ui Tooltip and define local variable

Signed-off-by: sunyeongchoi <suoung0716@gmail.com>

---------

Signed-off-by: sunyeongchoi <suoung0716@gmail.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@nikzayn @rumstead
feat: Adding the domain_hint as an optional field in OIDC configurati…
9458369 
…on (argoproj#18214)

* [18066] - Added DomainHint key in OIDCConfig struct

Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>

* [18066] - Added DomainHint in options for grantType

Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>

* [18066] - Auth0 readme.md --updated

Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>

---------

Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@dependabot @pasha-codefresh @rumstead
chore(deps): bump library/node from 21.6.2 to 21.7.0 (argoproj#17446)
ad87719 
Bumps library/node from 21.6.2 to 21.7.0.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
github-actions bot and others added 23 commits June 6, 2024 11:38
@github-actions @pasha-codefresh @rumstead
[Bot] docs: Update Snyk reports (argoproj#18471)
b83dd41 
Signed-off-by: CI <ci@argoproj.com>
Co-authored-by: CI <ci@argoproj.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
get server logs
fbdc3b5 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
get server logs
84fa144 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
get server logs
2691f30 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@Sn0rt @rumstead
feat: argocd cli support fish completion (argoproj#18484)
095a14a 
* feat: argocd cli support fish completion

Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>

* fix: update user doc for argocd fish completion

Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>

---------

Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
poke around
97cd0b5 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
poke around
60d81e7 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
poke around
eaf71c4 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@yyzxw @rumstead
fix: prevent preview changes sync (argoproj#18400)
74b1865 
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@aslafy-z @rumstead
chore: allow override of default e2e test args (argoproj#18415)
cce50c1 
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@dependabot @crenshaw-dev @rumstead
chore(deps): bump goreleaser/goreleaser-action from 5.1.0 to 6.0.0 (a…
65b39d6 
…rgoproj#18504)

* chore(deps): bump goreleaser/goreleaser-action from 5.1.0 to 6.0.0

Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.1.0 to 6.0.0.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](goreleaser/goreleaser-action@5742e2a...286f3b1)

---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* bump goreleaser version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@zencircle @rumstead
Update ingress.md (argoproj#18491)
e651548 
argoproj#16611

Signed-off-by: bhargav joshi <bhargav.joshi@gmail.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@akram @rumstead
feat: Consistent hashing with bounded loads algorithm for sharding (a…
d4a91ab 
…rgoproj#16564)

* Adds consistent hashing with bound loads sharding algorithm

Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>

* Make the assignement consistent accross all clusters
- The assignment or running of the algorithm has to be consistent across all the clusters. Changed the function to return a map where the consistent hash will be used to build the map

- Modifications to the createConsistentHashsingWithBoundLoads function. This will create the map for cluster to shard. Note that the list must be consistent across all shards so that is why the cluster list must be sorted before going through the consistent hash algorithm

Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>

* Extracting constant and simplifying boolean expression

Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>

* Update docs: consistent-hashing sharding algorithm

Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>

---------

Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@mmorel-35 @rumstead
fix: enable bool-compare rule from testifylint linter (argoproj#18414)
81d37f6 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@blakepettersson @jsoref
@alexmt @rumstead
docs: proposal for enhancing scoped repository credentials (argoproj#…
236eb95 
…18290)

* docs: proposal for enhancing scoped repository credentials

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* docs: flesh out section on project matching

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* docs: scope down proposal

For the sake of time and simplicity, we will not do any modifications
of `repo-creds` secrets for this proposal.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* docs: added feedback

Feedback from contributors' meeting, part one.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* docs: modification date

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* docs: remove use cases

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* docs: spec update

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* docs: clarify backward-compatability

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* chore: further clarification of backwards compatibility

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* Update docs/proposals/project-scoped-repository-enhancements.md

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* Update docs/proposals/project-scoped-repository-enhancements.md

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* Update docs/proposals/project-scoped-repository-enhancements.md

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* chore: behavior in line with current impl

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* docs: add reviewers

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* Update docs/proposals/project-scoped-repository-enhancements.md

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

---------

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@thepabloaguilar @rumstead
feat: changes git client to resolve semantic versioning tags (argopro…
e70af7a 
…j#17566)

* feat: changes git client to resolve semantic versioning tags

Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>

* docs: update documentation

Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>

* feat: simplify `resolveSemverRevision` method

Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>

* chore: add two more test cases

Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>

* chore: update `resolveSemverRevision` behavior

Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>

* chore: add end to end test

Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>

* chore: fix end to end test

Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>

* chore: improve semver constraint e2e testing

Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>

---------

Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@PaulSonOfLars @rumstead
Move code around to fix commit attribution. (argoproj#18515)
125e96e 
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@dependabot @rumstead
chore(deps-dev): bump @types/node from 20.14.1 to 20.14.2 in /ui-test (…
fa52525 
…argoproj#18519)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.14.1 to 20.14.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@dependabot @rumstead
chore(deps): bump bitnami/kubectl in /test/container (argoproj#18517)
0d7ac63 
Bumps bitnami/kubectl from `0aef4af` to `cdca6c1`.

---
updated-dependencies:
- dependency-name: bitnami/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@hawkesn @rumstead
docs: update notifications troubleshooting-errors doc with custom sec…
0bb50bb 
…ret (argoproj#18490)

* Update troubleshooting-errors with custom secret

Adding section for a custom secret

Signed-off-by: Nicholas Hawkes <hawkesn@gmail.com>

* Update troubleshooting-errors.md

Signed-off-by: Nicholas Hawkes <hawkesn@gmail.com>

---------

Signed-off-by: Nicholas Hawkes <hawkesn@gmail.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@blakepettersson @rumstead
Merge pull request from GHSA-87p9-x75h-p4j2
198e814 
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@pasha-codefresh @rumstead
Merge pull request from GHSA-3cqf-953p-h5cp
7b4c18a 
* fix: prevent enumerating by cluster name, return exact error for case when cluster exists and not

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* fix: prevent cluster enumeration by name

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* fix: prevent cluster enumeration by name

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* fix linter and add unit test

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* fix linter and add unit test

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* fix linter and add unit test

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* fix linter and add unit test

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* fix linter and add unit test

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
change coverage dir
eca2d9a 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead rumstead requested a review from a team as a code owner June 6, 2024 15:39
@rumstead
merge
1d7400d 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
more debug
7dce795 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
more debug
c33f382 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead rumstead closed this Jun 6, 2024
@rumstead rumstead deleted the feat/e2e-code-coverage branch June 6, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect test coverage from e2e tests