fix issue 201 can use hyphen in name #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now I can ``` mkdir try-temp.1 && cd "$_" dotnet new clean-arch ```
|
a lot of changes but there is only renaming actually |
askazakov
force-pushed
the
issue-201-respect-dash
branch
from
d8efbac
to
02c6385
Compare
|
Looking to merge this; can you resolve conflicts when you get a chance? Sorry for the delay in getting to it |
|
I merge main but encountered with #308 |
|
@ardalis should I bump version to 6.0.10? |
ardalis
reviewed
Jan 12, 2022
| @@ -20,4 +20,4 @@ jobs: | |||
| - name: Build with dotnet | |||
| run: dotnet build --configuration Release | |||
| - name: Test with dotnet | |||
| run: dotnet test ./Clean.Architecture.sln --configuration Release | |||
| run: dotnet test ./Clean.Architecture.1.sln --configuration Release | |||
There was a problem hiding this comment.
.sln file name should match with "sourceName" from template.json. .1 is one option to respect special symbol (like -) to correctly instantiate solution from template. Another option is to use _Clean.Architecture_ everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #201
see dotnet/templating#1168
now I can