CI: Add Repeat for ci-testlimited #33480
Conversation
WalkthroughWalkthroughThe changes enhance the CI workflow by introducing a new Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
/ci-test-limit runId=9091878910 repeat=2 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/9094690801. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| repeat: | ||
| description: "Repeat test count" | ||
| required: false | ||
| type: number | ||
| default: 1 |
There was a problem hiding this comment.
Add repeat input parameter to workflow_call section.
The repeat input parameter is added to the workflow_dispatch section but is missing from the workflow_call section. To ensure consistency and functionality when the workflow is called, add the repeat parameter to the workflow_call section as well.
workflow_call:
inputs:
pr:
description: "This is the PR number in case the workflow is being called in a pull request"
required: false
type: number
previous-workflow-run-id:
description: "This is the PR number in case the workflow is being called in a pull request"
required: false
type: number
default: 0
matrix:
description: "This is the matrix job number"
required: false
type: string
default: "[0, 1, 2]"
repeat:
description: "Repeat test count"
required: false
type: number
default: 1| @@ -231,6 +236,7 @@ | |||
| working-directory: app/client | |||
| run: | | |||
| yarn install --immutable | |||
| yarn add -D cypress-repeat | |||
There was a problem hiding this comment.
Tip
Codebase Verification
Ensure cypress-repeat is added to devDependencies.
The cypress-repeat package is not currently listed in the devDependencies section of the package.json file. Please add it to ensure it is correctly managed by Yarn.
Analysis chain
Ensure cypress-repeat is added to devDependencies.
Verify that cypress-repeat is added to the devDependencies in the package.json file to ensure it is correctly managed by Yarn.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify `cypress-repeat` is added to `devDependencies` in `package.json`.
# Test: Search for `cypress-repeat` in `devDependencies`. Expect: Entry exists.
rg --type json '"cypress-repeat"' app/client/package.json
Length of output: 59
Script:
#!/bin/bash
# Description: List the `devDependencies` section of `package.json` to verify the presence of `cypress-repeat`.
# Test: Output the `devDependencies` section.
jq '.devDependencies' app/client/package.json
Length of output: 4422
| @@ -359,6 +365,7 @@ | |||
| spec: ${{ env.specs_to_run }} | |||
| working-directory: app/client | |||
| env: "NODE_ENV=development" | |||
| command: npx cypress-repeat run -n ${{ inputs.repeat }} --until-passes | |||
There was a problem hiding this comment.
Tip
Codebase Verification
The cypress-repeat command may not work as expected because the cypress-repeat package is not found in the package.json files, indicating it is not installed as a dependency.
- Ensure that
cypress-repeatis added as a dependency in the appropriatepackage.jsonfile(s).
Analysis chain
Ensure cypress-repeat command works as expected.
Verify that the cypress-repeat command works as expected by running a test workflow with different repeat values to ensure it correctly repeats the tests until they pass.
To verify the correctness of the cypress-repeat command, we need to ensure that the cypress-repeat package is correctly installed and used in the codebase. We will search for references to cypress-repeat in the repository to confirm its presence and usage.
To further verify the presence of cypress-repeat, we will check the package.json file to see if it is listed as a dependency. This will help us confirm whether the package is installed and available for use.
To locate the package.json file and verify the presence of cypress-repeat as a dependency, we will first search for the package.json file in the repository and then check its contents.
To verify the presence of cypress-repeat as a dependency, we will check the contents of the located package.json files.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify `cypress-repeat` command works as expected.
# Test: Run a test workflow with different `repeat` values. Expect: Tests repeat until they pass.
gh workflow run ci-test-limited.yml -f repeat=3
Length of output: 230
Script:
#!/bin/bash
# Search for references to `cypress-repeat` in the repository to verify its presence and usage.
rg 'cypress-repeat'
Length of output: 19
Script:
#!/bin/bash
# Check the package.json file for the presence of `cypress-repeat` as a dependency.
rg 'cypress-repeat' package.json
Length of output: 85
Script:
#!/bin/bash
# Locate the package.json file in the repository.
fd package.json
Length of output: 508
Script:
#!/bin/bash
# Check the contents of the located package.json files for the presence of `cypress-repeat` as a dependency.
rg 'cypress-repeat' deploy/docker/fs/opt/appsmith/utils/package.json app/client/package.json app/client/packages/ast/package.json app/client/packages/storybook/package.json app/client/packages/rts/package.json app/client/packages/design-system/theming/package.json app/client/packages/design-system/widgets/package.json app/client/packages/icons/package.json app/client/packages/design-system/widgets-old/package.json app/client/packages/design-system/headless/package.json app/client/packages/dsl/package.json
Length of output: 510
|
/ci-test-limit runId=9091746568repeat=2 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/9094765279. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9094765279. |
|
/ci-test-limit runId=9091746568 repeat=2 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/9094807178. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9094807178. |
| spec: ${{ env.specs_to_run }} | ||
| working-directory: app/client | ||
| env: "NODE_ENV=development" | ||
| command: npx cypress-repeat run -n ${{ inputs.repeat }} --until-passes --browser ${{ env.BROWSER_PATH }} --config-file cypress_ci_custom.config.ts --spec ${{ env.specs_to_run }} --env "NODE_ENV=development" |
There was a problem hiding this comment.
Looks like a lot of the configuration under with is duplicated in CLI arguments here. Should we remove them under with, if they are no longer effective, since we're using a custom command?
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
|
This PR has been closed because of inactivity. |
Add Repeat for ci-testlimited