[SPARK-48351] JDBC Connectors - Add cast suite and fix found issue #46669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
reviewed
May 20, 2024
| import com.databricks.sql.connector.JDBCConnectorCastSuiteBase | ||
|
|
||
| import org.apache.spark.sql.connector.catalog.{Identifier, TableCatalog} | ||
| import org.apache.spark.sql.execution.datasources.v2.jdbc.MysqlTableCatalog |
There was a problem hiding this comment.
It seems that there are some imports in this file that do not exist in Apache Spark, such as com.databricks.sql.connector.JDBCConnectorCastSuiteBase and org.apache.spark.sql.execution.datasources.v2.jdbc.MysqlTableCatalog
There was a problem hiding this comment.
Thanks, I will fix it.
milastdbx
approved these changes
May 20, 2024
urosstan-db
commented
May 20, 2024
| override def visitCast(expr: String, exprDataType: DataType, dataType: DataType): String = { | ||
| dataType match { | ||
| case _: IntegralType => | ||
| // MySQL does not support cast to SHORT INT, BIGINT |
There was a problem hiding this comment.
nit: SHORT, INT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cast that are supported on spark, are not supported on external database.
For example, spark supports casting from float to timestamp, but many other databases does not support that.
Add new cast suite that can be reused by any connector (even non JDBC connectors)
Add suites for MySQL and Postgres.
Fix found issues for MySQL, Postgres and Snowflake.
Why are the changes needed?
To avoid exception because illegal cast was tried on remote data source.
Does this PR introduce any user-facing change?
Yes, type mapping is a little bit changed for Postgres connector.
How was this patch tested?
Integration suites.
Was this patch authored or co-authored using generative AI tooling?
No