[SPARK-48337][SQL] Fix precision loss for JDBC TIME values #46662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan @LuciferYang @dongjoon-hyun thanks |
dongjoon-hyun
approved these changes
May 21, 2024
|
Thank you, @yaooqinn . |
|
Merged to master. Thank you @dongjoon-hyun @LuciferYang |
|
late LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The method
java.sql.Time.toLocalTimediscards the fraction parts of time values. In this pull request, we avoid using it by calculating milliseconds to microseconds directly.Why are the changes needed?
fix precision loss
Does this PR introduce any user-facing change?
Yes,
11:22.33.456would result in1970-01-01 11:22.33where the fractional part was truncated.1970-01-01 11:22.33.456How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no