Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

Add support auto-capitalization-type for WXEditComponent #1597

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support auto-capitalization-type for WXEditComponent #1597

wants to merge 2 commits into from

Conversation

KorolZhu
Copy link
Contributor

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@weex-bot
Copy link

weex-bot commented Sep 29, 2018 •
edited

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

wqyfavor
wqyfavor reviewed Sep 30, 2018
View reviewed changes
Copy link
Member

@wqyfavor wqyfavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update apache/master so that project file will not be modified.

@KorolZhu
Copy link
Contributor Author

image

iOS sdk project build failed.

@KorolZhu
Merge branch 'master' of https://github.com/apache/incubator-weex
2a313e1 
# Conflicts:
#	ios/sdk/WeexSDK.xcodeproj/project.pbxproj
YorkShen
YorkShen suggested changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to master branch, as there is a conflict.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wqyfavor wqyfavor wqyfavor left review comments

@YorkShen YorkShen YorkShen requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KorolZhu @weex-bot @wqyfavor @YorkShen