Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove unused preventDefault on listener #55879

Closed

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented May 19, 2024

wrapListener was only invoked with wrapWithPreventDefault set to false.

The usage with true was removed by #46646.

`wrapListener` was only invoked with `wrapWithPreventDefault` set to `false`.
@JeanMeche JeanMeche marked this pull request as ready for review May 19, 2024 21:09
@pullapprove pullapprove bot requested a review from alxhub May 19, 2024 21:09
@dylhunn dylhunn removed the request for review from alxhub May 22, 2024 22:27
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: core Issues related to the framework runtime labels May 22, 2024
@ngbot ngbot bot added this to the Backlog milestone May 22, 2024
@dylhunn
Copy link
Contributor

dylhunn commented May 22, 2024

This PR was merged into the repository by commit a0690fe.

dylhunn pushed a commit that referenced this pull request May 22, 2024
`wrapListener` was only invoked with `wrapWithPreventDefault` set to `false`.

PR Close #55879
@dylhunn dylhunn closed this in a0690fe May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants