feat(common): permit data and blob URLs in ngSrc attribute #55878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `src` attribute supports blob and data URLs, and allowing the same behavior for `ngSrc` doesn't have any visible negative effects from my initial tests. Since there is no documented rationale for this, either in the original commit or official docs, I am assuming this is not a needed restriction and can be considered a regression. NOTE: If this restriction _was_ to be required, both documentation and linters should be updated accordingly. Various IDE's now assume Angular projects should use `ngSrc` as a replacement for `src` now, and will inform users of that. This reverts commit 801daf8.
paulyy-y
changed the title
dylhunn
added
area: common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
srcattribute supports blob and data URLs, and allowing the same behavior forngSrcdoesn't have any visible negative effects from my initial tests. Since there is no documented rationale for this, either in the original commit or official docs, I am assuming this is not a needed restriction and can be considered an unnecessary regression.NOTE: If this restriction was to be required, both documentation and linters should be updated accordingly. Various IDE's now assume Angular projects should use
ngSrcas a "drop-in" replacement forsrcnow, and will recommend that users change their attributes accordingly.This reverts commit 801daf8.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Blocks usage of
blob:ordata:URL's inngSrc.Issue Number: #55762
What is the new behavior?
Permits usage.
Does this PR introduce a breaking change?
Other information