fix(compiler): optimize track function that only passes $index #55872
+84
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
Currently we optimize methods that pass both `$index` and the item into a method. We can take this a step further by also optimizing calls that only pass `$index` into the first parameter.
crisbeto
force-pushed
the
track-by-index-optimization
branch
from
bf4d330
to
e27c97f
Compare
dylhunn
added
the
area: compiler
dylhunn
approved these changes
May 22, 2024
AndrewKushnir
added
target: patch
crisbeto
added
action: merge
|
This PR was merged into the repository by commit 6aeea69. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
May 23, 2024
Currently we optimize methods that pass both `$index` and the item into a method. We can take this a step further by also optimizing calls that only pass `$index` into the first parameter. PR Close #55872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we optimize methods that pass both
$indexand the item into a method. We can take this a step further by also optimizing calls that only pass$indexinto the first parameter.