Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: declare provideAnimationsAsync() function stable #55871

Closed
wants to merge 1 commit into from
Closed

docs: declare provideAnimationsAsync() function stable #55871

wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

This commit removes the @developerPreview label from the provideAnimationsAsync() function, effectively declaring it stable.

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir
docs: declare provideAnimationsAsync() function stable
04efe9b 
This commit removes the `@developerPreview` label from the `provideAnimationsAsync()` function, effectively declaring it stable.
@AndrewKushnir AndrewKushnir added area: animations action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate animations: async Issues related to async animation loading labels May 19, 2024
@AndrewKushnir AndrewKushnir added this to the v18 final milestone May 19, 2024
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 19, 2024
JeanMeche
JeanMeche approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

jelbourn
jelbourn approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

alxhub
alxhub approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 20, 2024
@AndrewKushnir
Copy link
Contributor Author

Caretaker note: docs-only change, no presubmit required.

@dylhunn
Copy link
Contributor

dylhunn commented May 21, 2024

This PR was merged into the repository by commit 14668e4.

dylhunn pushed a commit that referenced this pull request May 21, 2024
@AndrewKushnir @dylhunn
docs: declare provideAnimationsAsync() function stable (#55871)
77eb4ca 
This commit removes the `@developerPreview` label from the `provideAnimationsAsync()` function, effectively declaring it stable.

PR Close #55871
@dylhunn dylhunn closed this in 14668e4 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@JeanMeche JeanMeche JeanMeche approved these changes

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker animations: async Issues related to async animation loading area: animations area: docs Related to the documentation merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
v18 final
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AndrewKushnir @dylhunn @jelbourn @JeanMeche @alxhub