support send medata to config server #885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dragonYang200
commented
May 30, 2023
dragonYang200
commented
- 新增支持火山top网关加签算法BytedanceSign.h/BytedanceSign.cpp
- 新增元数据上报接口
- 心跳上报接口新增agent_machine_id字段
- 新增ConfigServiceClientBase基类，用以扩展字节火山configServer api调用接口
yyuuttaaoo
requested review from
henryzhx8,
yyuuttaaoo,
Takuka0311,
liuhaoyang and
messixukejia
and removed request for
henryzhx8
Takuka0311
reviewed
May 30, 2023
Takuka0311
reviewed
May 30, 2023
liuhaoyang
requested changes
May 30, 2023
yyuuttaaoo
requested changes
May 30, 2023
yyuuttaaoo
reviewed
May 30, 2023
Takuka0311
reviewed
May 31, 2023
messixukejia
requested changes
Jun 2, 2023
core/app_config/AppConfig.cpp
Outdated
| else if (port < 1 || port > 65535) | ||
| LOG_WARNING(sLogger, ("ilogtail_configserver_address", "illegal port")("port", port)); | ||
| else | ||
| mConfigServerAddresses.push_back(ConfigServerAddress(host, port)); | ||
| } | ||
|
|
||
| mConfigServerAvailable = true; | ||
| LoadStringParameter(mGatewayService, confJson, "gateway_service", "GATEWAY_SERVICE"); |
There was a problem hiding this comment.
下面这些参数需要确认下是否火山特有的，如果是的话建议放到VolcengineConfigServiceClient init中，因为这些都是client的内部参数
AppConfigti提供一个解析接口，供clinet调用
There was a problem hiding this comment.
读取ilogtail_config.json文件内容需要在GetStringParameter这个接口里面额外额外实现吗？还是在LoadAppConfig的时候用一个变量将ilogtail_config.json文件内容保存下来
| @@ -83,6 +83,7 @@ message HeartBeatRequest { | |||
| int32 interval = 8; // Agent's heartbeat interval | |||
| repeated ConfigInfo pipeline_configs = 9; // Information about the current PIPELINE_CONFIG held by the Agent | |||
messixukejia
requested changes
Jun 2, 2023
messixukejia
requested changes
Jun 3, 2023
| } | ||
| LOG_WARNING(sLogger, ("FlushCredential", "success")); | ||
| try { | ||
| mConfigServiceClient->SignHeader(request); |
There was a problem hiding this comment.
SignHeader FlushCredential 为什么对异常的处理方式不一样?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.