chore: Make DeltaOps public in RES CRDTs #32423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patriknw
commented
May 20, 2024
patriknw
commented
- For example when embedding the delta ops in application specific events it is useful to be able to access the underlying ORSet of the delta op, and it's value
* For example when embedding the delta ops in application specific events it is useful to be able to access the underlying ORSet of the delta op, and it's value
johanandren
approved these changes
May 20, 2024
| @@ -43,8 +43,7 @@ object ORSet { | |||
| def underlying: ORSet[A] | |||
| } | |||
|
|
|||
| /** INTERNAL API */ | |||
| @InternalApi private[akka] final case class AddDeltaOp[A](underlying: ORSet[A]) extends AtomicDeltaOp[A] { | |||
| final case class AddDeltaOp[A](underlying: ORSet[A]) extends AtomicDeltaOp[A] { | |||
There was a problem hiding this comment.
Since it is case classes this means copy, apply, unapply, etc becomes public API/set in stone in addition to the field accessor. Might be fine but worth noting.
There was a problem hiding this comment.
Good point. I think we can remove the case. Could still be useful with unapply and toString`
patriknw
commented
May 21, 2024
| @@ -55,7 +62,7 @@ object ORSet { | |||
| concatElementsMap(u.elementsMap.asInstanceOf[Map[A, Dot]]), | |||
| underlying.vvector.merge(u.vvector))) | |||
| case _: AtomicDeltaOp[A @unchecked] => DeltaGroup(Vector(this, that)) | |||
| case DeltaGroup(ops) => DeltaGroup(this +: ops) | |||
| case g: DeltaGroup[A @unchecked] => DeltaGroup(this +: g.ops) | |||
There was a problem hiding this comment.
@johanandren I removed the case
For some reason the match exhaustive checks don't work with these custom unapply. Maybe something with the type parameter? I rewrote them like this.
johanandren
approved these changes
May 21, 2024
|
I agree, I was prepared to add mima filter. I don't know if mima is clever enough to understand that previous versions were |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.