Don't use the cursor component if you need to render the controllers yourself #5074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs rebase. |
AdaRoseCannon
force-pushed
the
ar-cursor
branch
from
5019728
to
54ae26e
Compare
|
rebased |
|
|
|
This issue is okay to be merged I think but I will close 5076 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small addition to the cursor component that I was thinking about but was a bit slow adding it to the last PR. I still need to test to make sure it behaves as expected in headsets.
Description:
This disables the cursor component when controllers need to be rendered by the user (tracked controllers on opaque displays) because in these situations the user is probably using one of AFrame's controller inputs to render a controller and should put an additional cursor directly on those inputs.
Changes proposed: