Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for writing binary content to output #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lsadehaan
Copy link

@lsadehaan lsadehaan commented Mar 27, 2022

This pull is in relation to the issue here: #98

For my use-case I need to be able to write blocks of binary data to output files and without this change it is virtually impossible to achieve.

This change also opens various other possibilities, such as writing to a Stream or PipeWriter instead and returing a PipeReader to get the content from, which would improve efficiency for generation of very large output files.

P.S. I ran all tests with the updated version (updated to use the default implementation with template parameter ) and they all passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant