Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phantom deeplinks #2281

Open
wants to merge 23 commits into
base: V4
Choose a base branch
from
Open

Phantom deeplinks #2281

wants to merge 23 commits into from

Conversation

phoenixVS
Copy link
Collaborator

Breaking Changes

N/A

Changes

  • feat:
  • fix:
  • chore:

Associated Issues

closes #...

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview May 31, 2024 10:23am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview May 31, 2024 10:23am

@@ -145,7 +145,7 @@ export class W3mConnectView extends LitElement {

private announcedTemplate() {
return this.connectors.map(connector => {
if (connector.type !== 'ANNOUNCED' || CoreHelperUtil.isMobile()) {
if (connector.type !== 'ANNOUNCED') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svenvoskamp to double check, might be related to recent injected connector issue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed this check in the hotfix this morning, this was indeed causing issues that announced wallets didn't show up

Copy link
Contributor

@svenvoskamp svenvoskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the merge conflicts?

We only need to the changes from src/utils/defaultConfig.ts and solana/src/client.ts

@enesozturk
Copy link
Contributor

Could you please fix the merge conflicts?

We only need to the changes from src/utils/defaultConfig.ts and solana/src/client.ts

@phoenixVS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants