Fixed player sliding stuck bug #501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced OrthoNormalize with a double cross product which is slightly more performant. And added a small push away from walls when they are too steep.
kablouser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#416
#499
I think the issue lies within CharacterController. When calling Move() with a downwards direction it can get stuck if it's close enough to a very vertical wall (but not exactly 90 degrees).
issue.mp4
My solution was to add a small push away from the wall when they are too steep.
solved.mp4
Verification: replicate steps described in the issues.
Note
This is related to my other PR #500
This PR solves the issue #499 in a different way. But solves the older issue #416 which my other PR doesn't do.