Upgraded to Sentis v1.4.0-pre.3 #6097
Conversation
miguelalonsojr
force-pushed
the
develop-upgrade-sentis-1-4
branch
6 times, most recently
from
5ccc26b
to
0cd7f73
Compare
| @@ -5,7 +5,7 @@ | |||
| "unity": "2023.2", | |||
There was a problem hiding this comment.
Do you need to bump the version? And update the changelog?
There was a problem hiding this comment.
Changelog yes, version should be ok I think. Did 2023.3 come out already?
| @@ -165,10 +170,6 @@ internal void ComputeCdf(TensorProxy logProbs, int batch, int channelOffset, int | |||
| { | |||
| // Find the class maximum | |||
| var maxProb = float.NegativeInfinity; | |||
| if (logProbs.Device == DeviceType.GPU) | |||
| { | |||
| logProbs.data.MakeReadable(); | |||
There was a problem hiding this comment.
Should you add a CompleteOperationsAndDownload() in this method?
There was a problem hiding this comment.
Yes. Good catch. This is for legacy support, but yeah, should be CompleteOperationsAndDownload for non CPU.
| { | ||
| if (data.dataOnBackend.backendType != BackendType.CPU) | ||
| { | ||
| data?.Dispose(); |
There was a problem hiding this comment.
Why is it not needed to dispose when using CPU?
There was a problem hiding this comment.
There's no need to copy to the CPU mem. It's already there and accessible. This really only applies, at least for us, when using GPU backends.
| @@ -76,9 +74,10 @@ internal class ModelRunner | |||
| // D.logEnabled = m_Verbose; | |||
|
|
|||
| sentisModel = ModelLoader.Load(model); | |||
| sentisModelInfo = new SentisModelInfo(sentisModel, deterministicInference); | |||
There was a problem hiding this comment.
you could do
using var new SentisModelInfo(
To avoid having to call the dispose manually at the end (and which may not be called if an exception is thrown)
There was a problem hiding this comment.
ah. good point. will change.
miguelalonsojr
force-pushed
the
develop-upgrade-sentis-1-4
branch
from
6ab5de4
to
64ae11a
Compare
Proposed change(s)
Sentis v1.4 upgrade.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Dependency update.
Checklist
Other comments