Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added table for activitypub #20228

Merged
merged 2 commits into from
May 22, 2024
Merged

Added table for activitypub #20228

merged 2 commits into from
May 22, 2024

Conversation

aileen
Copy link
Member

@aileen aileen commented May 20, 2024 •
edited

ref MOM-122

  • Added prototype table for activitypub
  • The table is classed as prototype, as we're not expecting this to be the final version
  • Added json as valid type for schema test

@github-actions github-actions bot added the migration [pull request] Includes migration for review label May 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited by aileen

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@aileen aileen force-pushed the activitypub-aileen branch 4 times, most recently from 5229cdf to 5479f45 Compare May 20, 2024 16:16
@aileen aileen changed the title Added table for activitypub Added tables for activitypub May 20, 2024
@aileen aileen force-pushed the activitypub-aileen branch 2 times, most recently from b3bed10 to 080fb49 Compare May 20, 2024 20:21
allouis
allouis reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@allouis allouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments but otherwise 👍

.../core/core/server/data/migrations/versions/5.83/2024-05-16-17-57-13-add-activitypub-table.js Outdated Show resolved Hide resolved
daniellockyer
daniellockyer reviewed May 21, 2024
View reviewed changes
Copy link
Member

@daniellockyer daniellockyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking about adding more DB tables here: https://ghost.slack.com/archives/C02G9E68C/p1716276056319579

@aileen aileen force-pushed the activitypub-aileen branch 3 times, most recently from 2ba958a to 0340b9d Compare May 21, 2024 12:22
@aileen aileen changed the title Added tables for activitypub Added table for activitypub May 21, 2024
@aileen aileen force-pushed the activitypub-aileen branch 5 times, most recently from f927ccd to a3ada48 Compare May 21, 2024 18:24
@aileen
Added table for activitypub
87c8a82 
ref MOM-122

- Added prototype table for `activitypub`
- The table is classed as prototype, as we're not expecting this to be the final version
@allouis allouis changed the base branch from main to activitypub May 22, 2024 05:57
@allouis allouis merged commit ed5da45 into activitypub May 22, 2024
22 checks passed
@allouis allouis deleted the activitypub-aileen branch May 22, 2024 06:35
aileen added a commit that referenced this pull request May 22, 2024
@aileen
Added table for activitypub (#20228)
9fd385d 
refs https://linear.app/tryghost/issue/MOM-122

The data in ActivityPub is all different shapes - so we are using a JSON column to store it.
We've moved a few key pieces of data to their own columns to make searching easier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellockyer daniellockyer daniellockyer left review comments

@allouis allouis allouis left review comments

Assignees
No one assigned
Labels
migration [pull request] Includes migration for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aileen @daniellockyer @allouis