-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reagent bag & add sorting bag #29947
base: master
Are you sure you want to change the base?
Conversation
Fix an issue with the reagent bag Add cleanup item functionnality
Sorting logic is a lot more complex than just those five classifications, then by entry (by the use of sorted map)
Auto equipping bag change is problematic, it causes these bags to be unable to be looted to backpack (in case all bag slots are full and the bags are filled) |
Here are my answers
If you have any information about the sorting order, let me know and I'll change the code |
-Fix a bug no bags go to the backpack when all bags slot are taken -The poor quality (grey) item now go the most left bag instead of right after all the other items
OK I've just push the modification of the code. Once I know more about the sorting complexity, I'll change the way it works. By the way I've seen some bugs about the reagent bag :
|
bag flags implemented - cc92417 |
First of all thanks very much for the implementation of the bag flags system. With that I was able to take the bag flags into account! I fixed that (that's why there is a modification of the HandleChangeBagSlotFlag and HandleChangeBankBagSlotFlag in the itemHandler) After that and some testing I didn't find any issue. But if you find any, let me know so that I can fix them. About the last thing I need to do (the logic behind the sorting), I'll look for it later |
Now the sorting bag takes the item level into account and is way more Blizzlike
replace unsigned 64 to uint64
Remove multiple blank line
I update the code to add more complexity to the sorting code. There is also an issue with some special item for example Cold Iron Pick Anyway the way the sorting is done is : |
Update to master Branch
Sync with master
I've removed the magic number from my repo as well as the reagent bag slot fix. |
The bag cleanup order are :
Changes proposed:
Issues addressed:
#17564
Closes # (insert issue tracker number)
#17564
Tests performed:
Known issues and TODO list: (add/remove lines as needed)