-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TJ-9611 Added more translation #9770
base: develop
Are you sure you want to change the base?
Conversation
@AkshayKathiriya can you please resolve the merge conflicts? |
Hey @PriteshKiri , resolved the merge conflicts. |
Thanks @KathiriyaAkshay |
disabled={isLoading} | ||
> | ||
Cancel | ||
<ButtonSolid variant="tertiary" onClick={closeModal} data-cy="cancel-button" className="modal-footer-divider"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason for removing disabled
attribute from this button? If not we need to add it back
@@ -163,7 +161,6 @@ export function AppModal({ | |||
style={{ | |||
borderColor: errorText ? '#DB4324 !important' : 'initial', | |||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason for removing disabled
attribute from this button? If not we need to add it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KathiriyaAkshay thanks for the contribution. Can you check the comments added and revert?
TJ-9611 Added more translation