Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: do not suppress serial #5168

Merged

Conversation

vil02
Copy link
Member

@vil02 vil02 commented May 19, 2024

This PR includes serial into the active compiler warnings.

The BackEdgeException did not provide any additional useful information to the user, so I decided to remove it.

Continuation of #5165.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.57%. Comparing base (5ee98ee) to head (87052f1).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5168   +/-   ##
=========================================
  Coverage     38.57%   38.57%           
- Complexity     2378     2379    +1     
=========================================
  Files           516      516           
  Lines         15315    15313    -2     
  Branches       2957     2957           
=========================================
  Hits           5907     5907           
+ Misses         9122     9121    -1     
+ Partials        286      285    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review May 19, 2024 20:57
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@BamaCharanChhandogi BamaCharanChhandogi merged commit 8466219 into TheAlgorithms:master May 20, 2024
5 checks passed
@vil02 vil02 deleted the do_not_suppress_serial branch May 20, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants