Make admin product show simple and configurable page more granular #16267

TheMilek · 2024-05-16T21:04:43Z

Q	A
Branch?	2.0
Bug fix?	no
New feature?	no
BC breaks?	no
License	MIT

github-actions · 2024-05-16T21:43:16Z

Bunnyshell Preview Environment deleted

Available commands:

/bns:deploy to redeploy the environment

NoResponseMate · 2024-05-17T11:04:07Z

src/Sylius/Bundle/AdminBundle/Resources/config/app/twig_hooks/product/show.yaml

+        'sylius_admin.product.show.content.page_body.details.simple_product.shipping':
+            shipping_category:
+                template: '@SyliusAdmin/product/show/content/page_body/details/shared/shipping/shipping_category.html.twig'
+            width:
+                template: '@SyliusAdmin/product/show/content/page_body/details/shared/shipping/width.html.twig'
+            height:
+                template: '@SyliusAdmin/product/show/content/page_body/details/shared/shipping/height.html.twig'
+            depth:
+                template: '@SyliusAdmin/product/show/content/page_body/details/shared/shipping/depth.html.twig'
+            weight:
+                template: '@SyliusAdmin/product/show/content/page_body/details/shared/shipping/weight.html.twig'


Just a thought, but can we make a details.common hook and set it as one of the prefixes for data that's the same between configurable/simple?
Right now there's a lot of duplication.
Unless the prefixing logic is not yet released, in which case, welp.

...plates/product/show/content/page_body/details/configurable_product/details/pricing.html.twig

...uct/show/content/page_body/details/shared/pricing/lowest_price_before_the_discount.html.twig

NoResponseMate · 2024-05-17T11:24:10Z

...plates/product/show/content/page_body/details/configurable_product/details/pricing.html.twig

+                {% set channel = attribute(channels, channel_pricing.channelCode) %}
+                {% set currency_code = channel.baseCurrency.code %}
+                {% set price = channel_pricing.price %}
+                {% set original_price = channel_pricing.originalPrice ?? 0 %}


Why are you defaulting the originalPrice here, but the lowestPriceBeforeDiscount in the hooked template?

There is a problem with setting it, when it's null there is no variable I can base on in the hooked template and I've got problems with showing the -

.../templates/product/show/content/page_body/details/configurable_product/tab/product.html.twig

.../templates/product/show/content/page_body/details/configurable_product/tab/enabled.html.twig

...uct/show/content/page_body/details/shared/pricing/lowest_price_before_the_discount.html.twig

...AdminBundle/templates/product/show/content/page_body/details/shared/shipping/width.html.twig

...tes/product/show/content/page_body/details/configurable_product/tab/details_button.html.twig

src/Sylius/Bundle/AdminBundle/Resources/config/app/twig_hooks/product/show.yaml

GSadee · 2024-05-20T09:27:12Z

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "SYL-3366" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

GSadee · 2024-05-22T04:56:07Z

...dmin/product/viewing_price_history/accessing_price_history_from_configurable_product.feature

@@ -15,5 +15,5 @@ Feature: Accessing the price history from the configurable product show page
    Scenario: Being able to access the price history of variant from the configurable product show page
        Given I am browsing products
        When I access the "Wyborowa Vodka" product
-        And I access the price history of a product variant "Wyborowa Vodka Exquisite" for "United States" channel


This channel keyword could stay 🤔

src/Sylius/Bundle/AdminBundle/templates/order/show/content/sections/items/body/item.html.twig

...uct/show/content/page_body/details/shared/pricing/lowest_price_before_the_discount.html.twig

src/Sylius/Bundle/AdminBundle/templates/shared/helper/shop/product.html.twig

NoResponseMate · 2024-05-22T12:07:59Z

...uct/show/content/page_body/details/shared/pricing/lowest_price_before_the_discount.html.twig

+{% set channel = hookable_metadata.context.channel %}
+{% set variant = hookable_metadata.context.variant %}
+
+<td class="text-end" {{ sylius_test_html_attribute('lowest-price-before-the-discount', '%s.%s'|format(variant.code, channel.code)) }}>{% if channel_pricing.lowestPriceBeforeDiscount != null %}{{ money(channel_pricing.lowestPriceBeforeDiscount, currency_code) }}{% else %} - {% endif %}</td>


Suggested change

<td class="text-end" {{ sylius_test_html_attribute('lowest-price-before-the-discount', '%s.%s'|format(variant.code, channel.code)) }}>{% if channel_pricing.lowestPriceBeforeDiscount != null %}{{ money(channel_pricing.lowestPriceBeforeDiscount, currency_code) }}{% else %} - {% endif %}</td>

<td class="text-end" {{ sylius_test_html_attribute('lowest-price-before-the-discount', '%s.%s'|format(variant.code, channel.code)) }}>

{% if channel_pricing.lowestPriceBeforeDiscount != null %}

{{ money(channel_pricing.lowestPriceBeforeDiscount, currency_code) }}

{% else %}

-

{% endif %}

</td>

NoResponseMate · 2024-05-22T12:10:47Z

src/Sylius/Bundle/AdminBundle/templates/shared/helper/product.html.twig

Maybe change the name of the file to product_image?

NoResponseMate · 2024-05-22T12:12:40Z

...plates/product/show/content/page_body/details/configurable_product/details/pricing.html.twig

+                <th>{{ 'sylius.ui.channel'|trans }}</th>
+                <th class="text-end">{{ 'sylius.ui.price'|trans }}</th>
+                <th class="text-end">{{ 'sylius.ui.original_price'|trans }}</th>
+                <th class="text-end">{{ 'sylius.ui.lowest_price_before_discount'|trans }}</th>
+                <th class="text-end">{{ 'sylius.ui.discounted_by'|trans }}</th>
+                <th></th>
+            </tr>
+            </thead>
+            <tbody>
+            {% for channel_pricing in variant.channelPricings %}
+                {% set channel = attribute(channels, channel_pricing.channelCode) %}
+                {% set currency_code = channel.baseCurrency.code %}
+
+                <tr {{ sylius_test_html_attribute('variant-pricing', '%s.%s'|format(channel.code, variant.code)) }} >
+                    {% hook 'pricing' with { variant, channel, channel_pricing, currency_code } %}
+                </tr>
+            {% endfor %}


This is a bit problematic, I can add more data via the hook, but I cannot label them, since headers are static.

TheMilek · 2024-05-23T07:05:34Z

The copy of this PR is here

TheMilek added the Admin AdminBundle related issues and PRs. label May 16, 2024

TheMilek requested review from a team as code owners May 16, 2024 21:04

TheMilek force-pushed the SYL-3366 branch 2 times, most recently from c6efc07 to f31154d Compare May 17, 2024 05:48

NoResponseMate reviewed May 17, 2024

View reviewed changes

GSadee reviewed May 20, 2024

View reviewed changes

...tes/product/show/content/page_body/details/configurable_product/tab/details_button.html.twig Outdated Show resolved Hide resolved

src/Sylius/Bundle/AdminBundle/Resources/config/app/twig_hooks/product/show.yaml Outdated Show resolved Hide resolved

GSadee changed the base branch from bootstrap-admin-panel to 2.0 May 20, 2024 09:27

GSadee force-pushed the SYL-3366 branch from f31154d to e5d334d Compare May 20, 2024 09:27

TheMilek force-pushed the SYL-3366 branch 5 times, most recently from 3aac79b to 532c997 Compare May 21, 2024 13:15

mpysiak previously approved these changes May 22, 2024

View reviewed changes

GSadee reviewed May 22, 2024

View reviewed changes

TheMilek dismissed mpysiak’s stale review via 0f8b6db May 22, 2024 08:23

TheMilek force-pushed the SYL-3366 branch from 532c997 to 0f8b6db Compare May 22, 2024 08:23

GSadee approved these changes May 22, 2024

View reviewed changes

TheMilek added 8 commits May 22, 2024 13:18

Refactor Simple product show page

80cb135

Refactor Configurable product show page

7e6634a

Move the same tamplates to the shared directory

cf6fc29

Update configuration

c83cc9d

Resolve review comments

5038e51

extract boolean field from the grid

1c969ff

Adjust behat tests

c5a245b

resolve product images macro

fb35125

GSadee force-pushed the SYL-3366 branch from 0f8b6db to fb35125 Compare May 22, 2024 11:19

NoResponseMate reviewed May 22, 2024

View reviewed changes

TheMilek mentioned this pull request May 23, 2024

Make admin product show simple and configurable page more granular #16299

Merged

TheMilek closed this May 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make admin product show simple and configurable page more granular #16267

Make admin product show simple and configurable page more granular #16267

TheMilek commented May 16, 2024 •

edited

github-actions bot commented May 16, 2024 •

edited

NoResponseMate May 17, 2024

NoResponseMate May 17, 2024

TheMilek May 21, 2024

GSadee commented May 20, 2024

GSadee May 22, 2024

NoResponseMate May 22, 2024

NoResponseMate May 22, 2024

NoResponseMate May 22, 2024

TheMilek commented May 23, 2024

Make admin product show simple and configurable page more granular #16267

Make admin product show simple and configurable page more granular #16267

Conversation

TheMilek commented May 16, 2024 • edited

github-actions bot commented May 16, 2024 • edited

Bunnyshell Preview Environment deleted

NoResponseMate May 17, 2024

Choose a reason for hiding this comment

NoResponseMate May 17, 2024

Choose a reason for hiding this comment

TheMilek May 21, 2024

Choose a reason for hiding this comment

GSadee commented May 20, 2024

GSadee May 22, 2024

Choose a reason for hiding this comment

NoResponseMate May 22, 2024

Choose a reason for hiding this comment

NoResponseMate May 22, 2024

Choose a reason for hiding this comment

NoResponseMate May 22, 2024

Choose a reason for hiding this comment

TheMilek commented May 23, 2024

TheMilek commented May 16, 2024 •

edited

github-actions bot commented May 16, 2024 •

edited