Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract base form types for every entity used in AdminBundle #16257

Merged
merged 15 commits into from
May 23, 2024
Merged

Extract base form types for every entity used in AdminBundle #16257

merged 15 commits into from
May 23, 2024

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented May 14, 2024 •
edited

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

Based on #16238

@TheMilek TheMilek added the Admin AdminBundle related issues and PRs. label May 14, 2024
@TheMilek TheMilek requested review from a team as code owners May 14, 2024 12:57
@TheMilek TheMilek force-pushed the SYL-3513-change-extensions-to-form-types branch from c7eed75 to d8b4304 Compare May 14, 2024 13:12
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

Rafikooo
Rafikooo reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@Rafikooo Rafikooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this PR shouldn't be opened against the 2.0 branch.

src/Sylius/Bundle/AdminBundle/Form/Type/CatalogPromotionScopeType.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/Form/Type/CatalogPromotionScopeType.php Show resolved Hide resolved
@TheMilek TheMilek force-pushed the SYL-3513-change-extensions-to-form-types branch from 4584fe6 to abc5fae Compare May 15, 2024 06:34
@TheMilek
Copy link
Member Author

I wonder if this PR shouldn't be opened against the 2.0 branch.

Why?
This PR is only AdminBundle targeted 🤔

@TheMilek TheMilek force-pushed the SYL-3513-change-extensions-to-form-types branch 5 times, most recently from b3542e4 to 5572ec9 Compare May 15, 2024 09:33
This was referenced May 15, 2024
Merged
Merged
@Rafikooo
Copy link
Contributor

I wonder if this PR shouldn't be opened against the 2.0 branch.

Why? This PR is only AdminBundle targeted 🤔

I mean, these form changes are not necessarily related to bootstrap-admin-panel, but this branch will be merged into 2.0 so it's not a big deal.

Rafikooo
Rafikooo previously approved these changes May 15, 2024
View reviewed changes
@TheMilek TheMilek force-pushed the SYL-3513-change-extensions-to-form-types branch 2 times, most recently from 490abec to 6372a98 Compare May 16, 2024 06:55
GSadee added a commit that referenced this pull request May 17, 2024
@GSadee
refactor #16261 [Admin] Deprecate FormTypeExtensions (TheMilek)
62c41a7 
This PR was merged into the 1.14 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.14 <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | yes <!-- don't forget to update the UPGRADE-*.md file -->
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.12 or 1.13 branches
 - Features and deprecations must be submitted against the 1.14 branch
 - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
related to #16257 changes

Commits
-------

f6f0150 [Admin] Deprecate FormTypeExtensions
@TheMilek TheMilek force-pushed the SYL-3513-change-extensions-to-form-types branch from 6372a98 to 5222af2 Compare May 17, 2024 06:47
@GSadee GSadee changed the base branch from bootstrap-admin-panel to 2.0 May 20, 2024 09:32
@GSadee GSadee dismissed Rafikooo’s stale review May 20, 2024 09:32

The base branch was changed.

@TheMilek TheMilek mentioned this pull request May 20, 2024
Merged
GSadee added a commit that referenced this pull request May 21, 2024
@GSadee
refactor #16262 [ADR] Use Separate Base Form Types Instead of Type Ex…
a0d8085 
…tensions (TheMilek)

This PR was merged into the 1.14 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.14 <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.12 or 1.13 branches
 - Features and deprecations must be submitted against the 1.14 branch
 - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
REF: #16257

Commits
-------

208b53f [ADR] Use Separate Base Form Types Instead of Type Extensions.
GSadee added a commit that referenced this pull request May 22, 2024
@GSadee
refactor #16276 [Admin] Add base form type for every resource used in…
5ab993f 
… AdminBundle (TheMilek)

This PR was merged into the 1.14 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.14 <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.12 or 1.13 branches
 - Features and deprecations must be submitted against the 1.14 branch
 - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
related to #16257

Commits
-------

178c651 [Admin] Add base form type for every resource used in AdminBundle
db42466 Correct upgrade file
d57118b add config
@TheMilek TheMilek force-pushed the SYL-3513-change-extensions-to-form-types branch 2 times, most recently from c5e8622 to 1fbcf89 Compare May 22, 2024 13:41
NoResponseMate
NoResponseMate reviewed May 22, 2024
View reviewed changes
src/Sylius/Bundle/AdminBundle/Form/Type/CatalogPromotionScopeType.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/Form/Type/CountryType.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/Form/Type/CountryType.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/Form/Type/OrderType.php Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/Form/Type/ShippingMethodType.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/Form/Type/ProductType.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/Form/Type/AddressType.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/Form/Type/CatalogPromotionScopeType.php Outdated Show resolved Hide resolved
@TheMilek TheMilek force-pushed the SYL-3513-change-extensions-to-form-types branch from 1fbcf89 to 22fa361 Compare May 22, 2024 14:22
@TheMilek TheMilek force-pushed the SYL-3513-change-extensions-to-form-types branch from 22fa361 to ef3462d Compare May 22, 2024 14:26
@TheMilek TheMilek closed this May 22, 2024
@TheMilek TheMilek reopened this May 22, 2024
GSadee
GSadee reviewed May 23, 2024
View reviewed changes
...ius/Bundle/AdminBundle/Form/Type/CatalogPromotionScope/ForProductsScopeConfigurationType.php

public function getBlockPrefix(): string
{
return 'sylius_catalog_promotion_scope_for_products_configuration';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return 'sylius_catalog_promotion_scope_for_products_configuration';
return 'sylius_admin_catalog_promotion_scope_for_products_configuration';

@GSadee GSadee merged commit 694dcba into Sylius:2.0 May 23, 2024
24 of 33 checks passed
@GSadee
Copy link
Member

GSadee commented May 23, 2024

Thanks, Kamil! 🥇

@GSadee GSadee mentioned this pull request May 23, 2024
Merged
@TheMilek TheMilek deleted the SYL-3513-change-extensions-to-form-types branch May 23, 2024 05:51
Wojdylak added a commit that referenced this pull request May 23, 2024
@Wojdylak
[Admin] Change missing block prefix for admin (#16298)
b4802e2 
| Q               | A
|-----------------|-----
| Branch?         | 2.0
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file
-->
| Related tickets | fixes
#16257 (review)
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.12 or 1.13 branches
 - Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted
against the 2.0 branch
 - Make sure that the correct base branch is set

To be sure you are not breaking any Backward Compatibilities, check the
documentation:

https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate left review comments

@Wojdylak Wojdylak Wojdylak left review comments

@GSadee GSadee GSadee approved these changes

@mpysiak mpysiak mpysiak approved these changes

@Rafikooo Rafikooo Rafikooo left review comments

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TheMilek @Rafikooo @GSadee @NoResponseMate @Wojdylak @mpysiak