Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables Removal #195

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

Vukiz
Copy link

@Vukiz Vukiz commented May 6, 2021

added support to remove variables
It can be used to create dynamic menus in plugin - so you can add or remove variables on button clicked.

@weeeBox
Copy link
Member

weeeBox commented May 9, 2021

Hey @Vukiz, thanks for the PR! There're 2 things we need to address before merging:

  • Can you fix the broken unit test ion iOS: Native/iOS/LunarConsole/LunarConsoleTests/LUActionRegistryFilterTest.swift:54:7: Type 'LUActionRegistryFilterTest' does not conform to protocol 'LUActionRegistryFilterDelegate'?
  • Can you sign the Individual Contributor License Agreement (CLA)?

@weeeBox weeeBox changed the base branch from master to develop May 9, 2021 15:41
@Vukiz Vukiz force-pushed the variableremovalsupport branch 5 times, most recently from 6e2b127 to 15d17f3 Compare May 11, 2021 12:24
added interface implementation to failed test
@Vukiz
Copy link
Author

Vukiz commented May 11, 2021

Hey, @weeeBox! Finally won in a battle of me vs syntax.
Fixed issues with tests and signed CLA.

@weeeBox
Copy link
Member

weeeBox commented May 12, 2021

@Vukiz, cool - thanks! Things are a bit busy on my end right now - I'll try to review and merge until the end of the week!

@weeeBox
Copy link
Member

weeeBox commented May 16, 2021

@Vukiz, why do we need a projmods file here: Native/iOS/LunarConsole/LunarConsole/Lunar.projmods?

@Vukiz
Copy link
Author

Vukiz commented May 17, 2021

@Vukiz, why do we need a projmods file here: Native/iOS/LunarConsole/LunarConsole/Lunar.projmods?

Seems like I'm using XUPorter(https://github.com/onevcat/XUPorter) without knowing it. Without .projmods file after build xcode project I need to manually add Lunar lib to xcode project or to write a postprocessor so this files would be linked.
Should I delete this file?

@weeeBox
Copy link
Member

weeeBox commented May 17, 2021

There's a build post-processor already. I think we can delete the projmods file.

@Vukiz
Copy link
Author

Vukiz commented May 17, 2021

Yeah, for some reason that didn't work in my projects. Removed this file anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants