Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choosable FTP Account List (Before Upload) #7279

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jcommander
Copy link

So I gave ShareX a shot yesterday and was grateful it gave me a one-click solution to upload all kinds of files to FTP.
Unfortunately I was missing the Option to select an FTP Account in the 'before upload' window, so I added it. :)
image

It selects the FTP Account you selected for the current filetype by default.
It 'abuses' the TaskSettings.OverrideFTP setting but allowed for very few lines of code required for implementation.
Also this mechanic could be made toggleable with a new TaskSetting but I'd assume most people prefer this by default over having only one FTP option and an hidden OverrideFTP setting.
I started with creating RadioButtons per Account but migrated to a ComboBox for scalability, I tried putting it next to the RadioButton but it messed with the FlowLayoutPanel and/or RadioButton Grouping.

I've seen a few people wish for a feature like this so I thought I'd Share.
Originally posted by @bartico6 in #3992 (comment)

Bump, this would be great for SFTP/FTP uploads too - where I'd like to upload certain files to one FTP profile, and others to another profile - this is currently not possible in a generic way w/o tricking ShareX with the "text goes to X, images go to Y" setting.
Ideally, the user (if there are multiple profiles for the upload destination) is prompted which profile should be used - or each profile has an optional selection of files it accepts.
A workaround is to use workloads, yeah, but this could be simpler IMO.

@jcommander jcommander changed the title Generate ComboBox List for FTP Accounts in Destinations (Before Upload) Choosable FTP Account List (Before Upload) Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant