Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default empty state of sf::Shader #3025

Merged
merged 1 commit into from
May 20, 2024
Merged

Remove default empty state of sf::Shader #3025

merged 1 commit into from
May 20, 2024

Conversation

ChrisThrasher
Copy link
Member

Description

Expanding on #3020, #3021, and #3022.

@ChrisThrasher ChrisThrasher added this to the 3.0 milestone May 19, 2024
ChrisThrasher
ChrisThrasher commented May 19, 2024
View reviewed changes
examples/island/Island.cpp
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the way I had to change this file. I hope to find a cleaner solution but I think this technically works.

vittorioromeo
vittorioromeo requested changes May 19, 2024
View reviewed changes
Copy link
Member

@vittorioromeo vittorioromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good approach as usual, just a few nitpicks and a suggestion on how to improve the Island example

examples/island/Island.cpp Outdated Show resolved Hide resolved
examples/island/Island.cpp Outdated Show resolved Hide resolved
src/SFML/Graphics/Shader.cpp Outdated Show resolved Hide resolved
vittorioromeo
vittorioromeo requested changes May 19, 2024
View reviewed changes
examples/shader/Shader.cpp Outdated Show resolved Hide resolved
vittorioromeo
vittorioromeo approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@vittorioromeo vittorioromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9150767930

Details

  • 31 of 31 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 55.558%
Totals Coverage Status
Change from base Build 9150167137: -0.007%
Covered Lines: 11471
Relevant Lines: 19538
💛 - Coveralls

@ChrisThrasher ChrisThrasher merged commit 7234fc1 into master May 20, 2024
209 checks passed
@ChrisThrasher ChrisThrasher deleted the optional_shader branch May 20, 2024 03:04
@ChrisThrasher ChrisThrasher mentioned this pull request May 20, 2024
Merged
This was referenced Jun 4, 2024
Open
Merged
@ChrisThrasher ChrisThrasher mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vittorioromeo vittorioromeo vittorioromeo approved these changes

@eXpl0it3r eXpl0it3r Awaiting requested review from eXpl0it3r

@binary1248 binary1248 Awaiting requested review from binary1248

Assignees
No one assigned
Labels
feature m:sfml-graphics
Projects
SFML 3.0.0
Status: Done
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChrisThrasher @coveralls @vittorioromeo