Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to using the NULL audio backend if the default backends don't provide any devices. #2966

Merged
merged 1 commit into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 36 additions & 16 deletions src/SFML/Audio/AudioDevice.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include <SFML/System/Err.hpp>

#include <algorithm>
#include <array>
#include <ostream>


Expand Down Expand Up @@ -68,33 +69,52 @@ AudioDevice::AudioDevice()
// Create the context
m_context.emplace();

auto contextConfig = ma_context_config_init();
contextConfig.pLog = &*m_log;
auto contextConfig = ma_context_config_init();
contextConfig.pLog = &*m_log;
ma_uint32 deviceCount = 0;
const auto nullBackend = ma_backend_null;
const std::array<const ma_backend*, 2> backendLists{nullptr, &nullBackend};

if (const auto result = ma_context_init(nullptr, 0, &contextConfig, &*m_context); result != MA_SUCCESS)
for (const auto* backendList : backendLists)
{
m_context.reset();
err() << "Failed to initialize the audio context: " << ma_result_description(result) << std::endl;
return;
}
// We can set backendCount to 1 since it is ignored when backends is set to nullptr
if (const auto result = ma_context_init(backendList, 1, &contextConfig, &*m_context); result != MA_SUCCESS)
{
m_context.reset();
err() << "Failed to initialize the audio playback context: " << ma_result_description(result) << std::endl;
return;
}

// Count the playback devices
ma_uint32 deviceCount = 0;
// Count the playback devices
if (const auto result = ma_context_get_devices(&*m_context, nullptr, &deviceCount, nullptr, nullptr);
result != MA_SUCCESS)
{
err() << "Failed to get audio playback devices: " << ma_result_description(result) << std::endl;
return;
}

if (const auto result = ma_context_get_devices(&*m_context, nullptr, &deviceCount, nullptr, nullptr);
result != MA_SUCCESS)
{
err() << "Failed to get audio playback devices: " << ma_result_description(result) << std::endl;
return;
// Check if there are audio playback devices available on the system
if (deviceCount > 0)
break;

// Warn if no devices were found using the default backend list
if (backendList == nullptr)
err() << "No audio playback devices available on the system" << std::endl;

// Clean up the context if we didn't find any devices
ma_context_uninit(&*m_context);
}

// Check if there are audio playback devices available on the system
// If the NULL audio backend also doesn't provide a device we give up
if (deviceCount == 0)
{
err() << "No audio playback devices available on the system" << std::endl;
m_context.reset();
return;
}

if (m_context->backend == ma_backend_null)
err() << "Using NULL audio backend for playback" << std::endl;

// Create the playback device
m_playbackDevice.emplace();

Expand Down
45 changes: 41 additions & 4 deletions src/SFML/Audio/SoundRecorder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include <miniaudio.h>

#include <algorithm>
#include <array>
#include <optional>
#include <ostream>

Expand Down Expand Up @@ -187,16 +188,52 @@ SoundRecorder::SoundRecorder() : m_impl(std::make_unique<Impl>(this))
// Create the context
m_impl->context.emplace();

auto contextConfig = ma_context_config_init();
contextConfig.pLog = &*m_impl->log;
auto contextConfig = ma_context_config_init();
contextConfig.pLog = &*m_impl->log;
ma_uint32 deviceCount = 0;
const auto nullBackend = ma_backend_null;
const std::array<const ma_backend*, 2> backendLists{nullptr, &nullBackend};

if (const auto result = ma_context_init(nullptr, 0, &contextConfig, &*m_impl->context); result != MA_SUCCESS)
for (const auto* backendList : backendLists)
{
// We can set backendCount to 1 since it is ignored when backends is set to nullptr
if (const auto result = ma_context_init(backendList, 1, &contextConfig, &*m_impl->context); result != MA_SUCCESS)
{
m_impl->context.reset();
err() << "Failed to initialize the audio capture context: " << ma_result_description(result) << std::endl;
return;
}

// Count the capture devices
if (const auto result = ma_context_get_devices(&*m_impl->context, nullptr, nullptr, nullptr, &deviceCount);
result != MA_SUCCESS)
{
err() << "Failed to get audio capture devices: " << ma_result_description(result) << std::endl;
return;
}

// Check if there are audio capture devices available on the system
if (deviceCount > 0)
break;

// Warn if no devices were found using the default backend list
if (backendList == nullptr)
err() << "No audio capture devices available on the system" << std::endl;

// Clean up the context if we didn't find any devices
ma_context_uninit(&*m_impl->context);
}

// If the NULL audio backend also doesn't provide a device we give up
if (deviceCount == 0)
{
m_impl->context.reset();
err() << "Failed to initialize the audio context: " << ma_result_description(result) << std::endl;
return;
}

if (m_impl->context->backend == ma_backend_null)
err() << "Using NULL audio backend for capture" << std::endl;

// Create the capture device
m_impl->initialize();
}
Expand Down