Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PCH builds with 'BUILD_SHARED_LIBS=1' #2901

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Allow PCH builds with 'BUILD_SHARED_LIBS=1' #2901

wants to merge 7 commits into from

Conversation

vittorioromeo
Copy link
Member

Let's see if CI is happy...

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.13%. Comparing base (6eaf300) to head (741a78a).
Report is 33 commits behind head on master.

❗ Current head 741a78a differs from pull request most recent head eda12d0. Consider uploading reports for the commit eda12d0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2901      +/-   ##
==========================================
+ Coverage   43.65%   44.13%   +0.47%     
==========================================
  Files         253      254       +1     
  Lines       20940    21286     +346     
  Branches     5139     5200      +61     
==========================================
+ Hits         9142     9394     +252     
- Misses      10785    11053     +268     
+ Partials     1013      839     -174

see 87 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2386653...eda12d0. Read the comment docs.

@eXpl0it3r
Copy link
Member

Let's see if CI is happy...

Did you intend to set SFML_ENABLE_PCH in the CI somewhere, because as is, this is not tested on the CI and thus won't make CI unhappy 😄

@eXpl0it3r eXpl0it3r added this to the 3.0 milestone Feb 8, 2024
eXpl0it3r
eXpl0it3r reviewed Feb 8, 2024
View reviewed changes
CMakeLists.txt Outdated

if(SFML_ENABLE_PCH AND SFML_OS_MACOS)
message(FATAL_ERROR "Precompiled headers are currently not supported in macOS builds")
endif()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave the option (and error) at the original position as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will move it back.

@vittorioromeo vittorioromeo mentioned this pull request Feb 9, 2024
Merged
@SFML SFML deleted a comment from vittorioromeo Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eXpl0it3r eXpl0it3r eXpl0it3r left review comments

@Bromeon Bromeon Awaiting requested review from Bromeon

@binary1248 binary1248 Awaiting requested review from binary1248

@ChrisThrasher ChrisThrasher Awaiting requested review from ChrisThrasher

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature m:config
Projects
SFML 3.0.0
Status: In Review
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vittorioromeo @eXpl0it3r