Improves some log messages and fixes a typo #6773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AcK77
requested changes
May 14, 2024
Co-authored-by: Ac_K <Acoustik666@gmail.com>
AcK77
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this commit is to improve the somewhat cryptic wording of the log message that shows up when previously specified game directories no longer exist. I removed the config file's name from the message since the vast majority of users do not and should never interact with that file directly.
As for the change in
ConfigurationState.cs: I noticed floats (like the one forAudioVolume) got formatted with the local culture for some reason, so I made it use the invariant culture.